From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11423 invoked by alias); 21 Sep 2018 16:49:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11394 invoked by uid 89); 21 Sep 2018 16:49:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:719, management, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Sep 2018 16:49:53 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E0863C057FAB; Fri, 21 Sep 2018 16:49:51 +0000 (UTC) Received: from localhost (unknown [10.33.36.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 78E6D8208B; Fri, 21 Sep 2018 16:49:51 +0000 (UTC) Date: Fri, 21 Sep 2018 17:13:00 -0000 From: Jonathan Wakely To: =?iso-8859-1?Q?Fran=E7ois?= Dumont Cc: "libstdc++@gcc.gnu.org" , gcc-patches Subject: Re: [PATCH] PR libstdc++/87135 Rehash only when necessary (LWG2156) Message-ID: <20180921164950.GO23172@redhat.com> References: <1ad7ad86-0f0c-e8b0-8f29-2b5303718988@gmail.com> <20180918084159.GV23172@redhat.com> <712c7e85-fd7b-5849-85b6-14784266d567@gmail.com> <20180919110724.GC23172@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.2 (2017-12-15) X-SW-Source: 2018-09/txt/msg01248.txt.bz2 On 21/09/18 18:10 +0200, François Dumont wrote: >Here is the patch complement. > >load_factor.cc failure revealed a bug in load factor management. Now >computation of _M_next_resize is consistent throughout the different >places where it is set. > >The 2 other tests only have to be adapted. > >    PR libstdc++/87135 >    * src/c++11/hashtable_c++0x.cc (_Prime_rehash_policy::_M_next_bkt): >    Use __builtin_floor to compute _M_next_resize. >    * testsuite/23_containers/unordered_set/hash_policy/71181.cc: Adapt. >    * testsuite/23_containers/unordered_set/hash_policy/prime_rehash.cc: >    Adapt. > >Now fully tested under x86_64. > >Ok to commit ? OK, thanks.