From: Jonathan Wakely <jwakely@redhat.com>
To: Marc Glisse <marc.glisse@inria.fr>
Cc: Ville Voutilainen <ville.voutilainen@gmail.com>,
libstdc++ <libstdc++@gcc.gnu.org>,
gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: vector<bool> _M_start and 0 offset
Date: Mon, 01 Oct 2018 12:45:00 -0000 [thread overview]
Message-ID: <20181001121259.GL23172@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1809291055420.22414@stedding.saclay.inria.fr>
On 29/09/18 10:56 +0200, Marc Glisse wrote:
>Hello,
>
>here is a clang-friendly version of the patch (same changelog), tested
>a while ago. Is it ok or do you prefer something like the
>
>+ if(this->_M_impl._M_start._M_offset != 0) __builtin_unreachable();
>
>version suggested by François?
I don't think __builtin_unreachable would improve the clarity of the code.
The patch is OK for trunk, thanks.
next prev parent reply other threads:[~2018-10-01 12:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 14:12 Marc Glisse
2018-09-17 16:29 ` Jonathan Wakely
2018-09-17 18:20 ` Marc Glisse
2018-09-17 18:55 ` Jonathan Wakely
2018-09-17 19:10 ` Ville Voutilainen
2018-09-17 19:12 ` Jonathan Wakely
2018-09-17 19:18 ` Jonathan Wakely
2018-09-17 19:22 ` Marc Glisse
2018-09-17 19:28 ` Marc Glisse
2018-09-17 19:50 ` Jonathan Wakely
2018-09-17 20:05 ` Marc Glisse
2018-09-29 11:06 ` Marc Glisse
2018-10-01 12:45 ` Jonathan Wakely [this message]
2018-09-17 19:36 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001121259.GL23172@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=marc.glisse@inria.fr \
--cc=ville.voutilainen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).