From: Jakub Jelinek <jakub@redhat.com>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] Implement P0840, language support for empty objects.
Date: Wed, 03 Oct 2018 16:30:00 -0000 [thread overview]
Message-ID: <20181003160543.GA23346@laptop.zalov.cz> (raw)
In-Reply-To: <20181003155615.5395-1-jason@redhat.com>
On Wed, Oct 03, 2018 at 11:56:15AM -0400, Jason Merrill wrote:
> --- a/gcc/c-family/c-lex.c
> +++ b/gcc/c-family/c-lex.c
> @@ -356,6 +356,8 @@ c_common_has_attribute (cpp_reader *pfile)
> || is_attribute_p ("nodiscard", attr_name)
> || is_attribute_p ("fallthrough", attr_name))
> result = 201603;
> + else if (is_attribute_p ("no_unique_address", attr_name))
> + result = 20180312;
Seems for all other attributes we return either 0, 1 or yyyymm, you return
here yyyymmdd, is that intentional? If users think it is yyyymm, then
they'd read it as December 201803.
Jakub
next prev parent reply other threads:[~2018-10-03 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 16:05 Jason Merrill
2018-10-03 16:30 ` Jakub Jelinek [this message]
2018-10-10 14:36 ` [C++ PATCH] Fix up __has_cpp_attribute (no_unique_address) Jakub Jelinek
2018-10-11 0:57 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003160543.GA23346@laptop.zalov.cz \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).