From: James Greenhalgh <james.greenhalgh@arm.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
nd@arm.com
Subject: Re: [PATCH] Provide extension hint for aarch64 target (PR driver/83193).
Date: Tue, 16 Oct 2018 17:35:00 -0000 [thread overview]
Message-ID: <20181016165748.GA36182@arm.com> (raw)
In-Reply-To: <09de624a-ee68-1106-f92e-e856b060ee1e@suse.cz>
On Mon, Oct 08, 2018 at 05:34:52AM -0500, Martin Liška wrote:
> Hi.
>
> I'm attaching updated version of the patch.
Can't say I'm thrilled by the allocation/free (aarch64_parse_extension
allocates, everyone else has to free) responsibilities here.
If you can clean that up I'd be much happier. The overall patch is OK.
Thanks,
James
> From d36974540cda9fb0e159103fdcf92d26ef2f1b94 Mon Sep 17 00:00:00 2001
> From: marxin <mliska@suse.cz>
> Date: Thu, 4 Oct 2018 16:31:49 +0200
> Subject: [PATCH] Provide extension hint for aarch64 target (PR driver/83193).
>
> gcc/ChangeLog:
>
> 2018-10-05 Martin Liska <mliska@suse.cz>
>
> PR driver/83193
> * common/config/aarch64/aarch64-common.c (aarch64_parse_extension):
> Add new argument invalid_extension.
> (aarch64_get_all_extension_candidates): New function.
> (aarch64_rewrite_selected_cpu): Add NULL to function call.
> * config/aarch64/aarch64-protos.h (aarch64_parse_extension): Add
> new argument.
> (aarch64_get_all_extension_candidates): New function.
> * config/aarch64/aarch64.c (aarch64_parse_arch): Add new
> argument invalid_extension.
> (aarch64_parse_cpu): Likewise.
> (aarch64_print_hint_for_extensions): New function.
> (aarch64_validate_mcpu): Provide hint about invalid extension.
> (aarch64_validate_march): Likewise.
> (aarch64_handle_attr_arch): Pass new argument.
> (aarch64_handle_attr_cpu): Provide hint about invalid extension.
> (aarch64_handle_attr_isa_flags): Likewise.
>
> gcc/testsuite/ChangeLog:
>
> 2018-10-05 Martin Liska <mliska@suse.cz>
>
> PR driver/83193
> * gcc.target/aarch64/spellcheck_7.c: New test.
> * gcc.target/aarch64/spellcheck_8.c: New test.
> * gcc.target/aarch64/spellcheck_9.c: New test.
> ---
> gcc/common/config/aarch64/aarch64-common.c | 24 +++++-
> gcc/config/aarch64/aarch64-protos.h | 4 +-
> gcc/config/aarch64/aarch64.c | 75 +++++++++++++++----
> .../gcc.target/aarch64/spellcheck_7.c | 12 +++
> .../gcc.target/aarch64/spellcheck_8.c | 13 ++++
> .../gcc.target/aarch64/spellcheck_9.c | 13 ++++
> 6 files changed, 121 insertions(+), 20 deletions(-)
> create mode 100644 gcc/testsuite/gcc.target/aarch64/spellcheck_7.c
> create mode 100644 gcc/testsuite/gcc.target/aarch64/spellcheck_8.c
> create mode 100644 gcc/testsuite/gcc.target/aarch64/spellcheck_9.c
>
next prev parent reply other threads:[~2018-10-16 16:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 15:49 Martin Liška
2018-08-01 13:56 ` Martin Liška
2018-08-23 11:01 ` Martin Liška
2018-09-19 18:11 ` Martin Liška
2018-10-04 8:16 ` Martin Liška
2018-10-04 10:32 ` Kyrill Tkachov
2018-10-04 14:35 ` Martin Liška
2018-10-08 10:53 ` Martin Liška
2018-10-16 16:58 ` Kyrill Tkachov
2018-10-16 17:35 ` James Greenhalgh [this message]
2018-10-22 14:03 ` Martin Liška
2018-10-23 13:48 ` [PATCH] Remove extra memory allocation of strings Martin Liška
2018-11-01 10:13 ` Martin Liška
2018-11-08 12:20 ` Kyrill Tkachov
2018-11-08 15:22 ` James Greenhalgh
2018-10-23 19:02 ` [PATCH] Provide extension hint for aarch64 target (PR driver/83193) Martin Sebor
2018-10-24 11:48 ` Martin Liška
2018-10-24 19:28 ` Martin Sebor
2018-10-25 12:36 ` Martin Liška
2018-10-30 19:50 ` James Greenhalgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016165748.GA36182@arm.com \
--to=james.greenhalgh@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@foss.arm.com \
--cc=mliska@suse.cz \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).