From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80998 invoked by alias); 25 Oct 2018 17:29:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 80984 invoked by uid 89); 25 Oct 2018 17:29:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=built-ins X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Oct 2018 17:29:11 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id w9PHT44F004236; Thu, 25 Oct 2018 12:29:05 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id w9PHSwBm004215; Thu, 25 Oct 2018 12:28:58 -0500 Date: Thu, 25 Oct 2018 18:43:00 -0000 From: Segher Boessenkool To: Bill Schmidt Cc: GCC Patches Subject: Re: [PATCH, rs6000] Replace comparison operators with vec_cmp* in intrinsic compatibility headers Message-ID: <20181025172857.GB5205@gate.crashing.org> References: <94afcb48-aa72-dd2b-375c-d747257552df@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94afcb48-aa72-dd2b-375c-d747257552df@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg01610.txt.bz2 Hi! On Wed, Oct 24, 2018 at 02:30:10PM -0500, Bill Schmidt wrote: > Due to some unfortunate history, not all compilers currently have correct result > types produced for comparison operators on vector types. For compatibility > purposes, this patch replaces those with vec_cmp* built-ins. It also cleans up > some silly type usages and formatting in the affected functions. Those compilers really need to be fixed, this isn't a tiny detail they get wrong. But, this patch makes the code more readable, so okay. Thanks! Segher > 2018-10-24 Bill Schmidt > Jinsong Ji > > * gcc/config/rs6000/emmintrin.h (_mm_sll_epi16): Replace > comparison operators with vec_cmp* for compatibility due to > unfortunate history; clean up formatting and use types more > appropriately. > (_mm_sll_epi32): Likewise. > (_mm_sll_epi64): Likewise. > (_mm_srl_epi16): Likewise. > (_mm_srl_epi32): Likewise. > (_mm_srl_epi64): Likewise.