From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106248 invoked by alias); 1 Nov 2018 15:58:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 106234 invoked by uid 89); 1 Nov 2018 15:58:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,SPF_PASS autolearn=ham version=3.3.2 spammy=August, august, Mike, mike X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Nov 2018 15:58:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mathworks.com; s=mimecast20180117; t=1541087884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hOmh8WSGE6Znz+LhwKJCVJVR4LaTQ57626iXcpNf8Hc=; b=PCYhhsOVIKBIj0IW33EMnZXIfqO8fbJi2ox5hpP9HQAHmWEIK3GAVm4qwaV7qwNgFy223yidCVKHJOi5NOacN6lwQak8YTyh90LcuhQ0uLdhJNepLfw9+2tcGWAMHDo3tlnAsGOCuGVoMKzl0Ztx5FGewsm4fmUe7w3VS0hguU4= Received: from NAM05-CO1-obe.outbound.protection.outlook.com (mail-co1nam05lp0087.outbound.protection.outlook.com [216.32.181.87]) (Using TLS) by dkim.mimecast.com with ESMTP id us-mta-243-1VrciGH1PMmwT6PrV6OmrQ-1; Thu, 01 Nov 2018 11:58:02 -0400 Received: from CO2PR05CA0061.namprd05.prod.outlook.com (2603:10b6:102:2::29) by BY1PR0501MB1110.namprd05.prod.outlook.com (2a01:111:e400:4804::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.18; Thu, 1 Nov 2018 15:57:59 +0000 Received: from DM3NAM05FT050.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::204) by CO2PR05CA0061.outlook.office365.com (2603:10b6:102:2::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1294.8 via Frontend Transport; Thu, 1 Nov 2018 15:57:59 +0000 Received: from exedge.mathworks.com (144.212.100.42) by DM3NAM05FT050.mail.protection.outlook.com (10.152.98.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1318.5 via Frontend Transport; Thu, 1 Nov 2018 15:57:58 +0000 Received: from ex16-01-ah.mathworks.com (172.31.80.219) by ex16edge-00-ah.mathworks.com (172.31.187.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1466.3; Thu, 1 Nov 2018 11:56:54 -0400 Received: from ex16-00-ah.mathworks.com (172.31.39.22) by ex16-01-ah.mathworks.com (172.31.80.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1466.3; Thu, 1 Nov 2018 11:57:36 -0400 Received: from mail-vif.mathworks.com (144.212.95.101) by ex16-00-ah.mathworks.com (172.31.39.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1466.3 via Frontend Transport; Thu, 1 Nov 2018 11:57:36 -0400 Received: from mgulick-deb9-64.dhcp.mathworks.com (mgulick-deb9-64.dhcp.mathworks.com [172.21.82.68]) by mail-vif.mathworks.com (8.14.7/8.14.7) with ESMTP id wA1Fvam8015415; Thu, 1 Nov 2018 11:57:36 -0400 Received: (from mgulick@localhost) by mgulick-deb9-64.dhcp.mathworks.com (8.15.2/8.15.2/Submit) id wA1FvaJY019047; Thu, 1 Nov 2018 11:57:36 -0400 From: Mike Gulick To: CC: David Malcolm , Mike Gulick Subject: [PATCH v3 0/3] PR preprocessor/83173: C preprocessor generates incorrect linemarkers Date: Thu, 01 Nov 2018 15:58:00 -0000 Message-ID: <20181101155607.11388-1-mgulick@mathworks.com> In-Reply-To: <7d281f10-a4e0-d81e-c405-d77ceda86f5b@mathworks.com> References: <7d281f10-a4e0-d81e-c405-d77ceda86f5b@mathworks.com> MIME-Version: 1.0 Return-Path: Mike.Gulick@mathworks.com Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2018-11/txt/msg00025.txt.bz2 Hi, Changes in v3: I haven't gotten a response in several months, so I'm reposting these patches. I split up the enhancement to the -fdump-internal-locations output from the actual bugfix. Hopefully this will make these easier to review. I rebased these patches on the gcc master and had to make one minor change to patch 3/3 to account for removal of the ORDINARY_MAP_INCLUDER_FILE_INDEX macro that was made back in August. We have been using this patch internally for the last 9 months without any issues, and the some other users have indicated the same on the bug report. Please let me know if you have any feedback, and how I should proceed. I do not have gcc contributor paperwork in place, as I believe that needs to be initiated by a maintainer, but I do have an employer disclaimer already approved, so the process should be simple. Thanks, Mike Mike Gulick (3): PR preprocessor/83173: Additional check before decrementing highest_location PR preprocessor/83173: New test PR preprocessor/83173: Enhance -fdump-internal-locations output gcc/input.c | 49 ++- .../plugin/location-overflow-test-pr83173-1.h | 2 + .../plugin/location-overflow-test-pr83173-2.h | 2 + .../plugin/location-overflow-test-pr83173.c | 21 ++ .../plugin/location-overflow-test-pr83173.h | 2 + .../gcc.dg/plugin/location_overflow_plugin.c | 13 +- gcc/testsuite/gcc.dg/plugin/plugin.exp | 3 +- libcpp/files.c | 32 +- libcpp/location-example.txt | 333 ++++++++++-------- 9 files changed, 301 insertions(+), 156 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/plugin/location-overflow-test-pr83= 173-1.h create mode 100644 gcc/testsuite/gcc.dg/plugin/location-overflow-test-pr83= 173-2.h create mode 100644 gcc/testsuite/gcc.dg/plugin/location-overflow-test-pr83= 173.c create mode 100644 gcc/testsuite/gcc.dg/plugin/location-overflow-test-pr83= 173.h --=20 2.19.1