public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Update libquadmath fmaq from glibc, fix nanq issues
Date: Wed, 07 Nov 2018 06:47:00 -0000	[thread overview]
Message-ID: <20181107064659.GA11625@tucnak> (raw)
In-Reply-To: <alpine.DEB.2.21.1811070028500.9324@digraph.polyomino.org.uk>

On Wed, Nov 07, 2018 at 12:29:21AM +0000, Joseph Myers wrote:
> This patch extends update-quadmath.py to update fmaq from glibc.
> 
> The issue in that function was that quadmath-imp.h had a struct in a
> union with mant_high and mant_low fields (up to 64-bit) whereas glibc
> has mantissa0, mantissa1, mantissa2 and mantissa3 (up to 32-bit).  The
> patch changes those fields to be the same as in glibc, moving printf /
> strtod code that also uses those fields back to closer to the glibc
> form.  This allows fmaq to be updated automatically from glibc (which
> brings in at least one bug fix from glibc from 2015).
> 
> nanq was also using the mant_high field name, and had other issues: it
> only partly initialized the union from which a value was returned, and
> setting mant_high to 1 meant a signaling NaN would be returned rather
> than a quiet NaN.  This patch fixes those issues as part of updating
> it to use the changed interfaces (but does not fix the issue of not
> using the argument).
> 
> Bootstrapped with no regressions on x86_64-pc-linux-gnu.

Don't know about the dropping of HAVE_FENV_H/USE_FENV_H stuff, don't we
support libquadmath on targets that don't have fenv.h?
In other sources, like e.g. expq.c, the USE_FENV_H guards are still kept.

	Jakub

  reply	other threads:[~2018-11-07  6:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07  0:29 Joseph Myers
2018-11-07  6:47 ` Jakub Jelinek [this message]
2018-11-07 13:40   ` Joseph Myers
2018-11-07 13:45     ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181107064659.GA11625@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).