From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14360 invoked by alias); 7 Nov 2018 16:32:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14347 invoked by uid 89); 7 Nov 2018 16:32:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:ESMTPA X-HELO: pio-pvt-msa1.bahnhof.se Received: from pio-pvt-msa1.bahnhof.se (HELO pio-pvt-msa1.bahnhof.se) (79.136.2.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Nov 2018 16:32:57 +0000 Received: from localhost (localhost [127.0.0.1]) by pio-pvt-msa1.bahnhof.se (Postfix) with ESMTP id 868173F98F; Wed, 7 Nov 2018 17:32:55 +0100 (CET) Received: from pio-pvt-msa1.bahnhof.se ([127.0.0.1]) by localhost (pio-pvt-msa1.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pbGqq7TUAIbh; Wed, 7 Nov 2018 17:32:50 +0100 (CET) Received: from localhost (h-41-252.A163.priv.bahnhof.se [46.59.41.252]) (Authenticated sender: mb547485) by pio-pvt-msa1.bahnhof.se (Postfix) with ESMTPA id 179823F73F; Wed, 7 Nov 2018 17:32:50 +0100 (CET) Date: Wed, 07 Nov 2018 16:32:00 -0000 From: Fredrik Noring To: gcc-patches@gcc.gnu.org Cc: "Maciej W. Rozycki" , =?utf-8?Q?J=C3=BCrgen?= Urban , Matthew Fortune Subject: Re: [PATCH v2] MIPS: Default to --with-llsc for the R5900 Linux target as well Message-ID: <20181107163249.GA6040@sx9> References: <7a209bd56cc4bb5d71dcf37cc7f5878ffb05d40f.1539971239.git.noring@nocrew.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7a209bd56cc4bb5d71dcf37cc7f5878ffb05d40f.1539971239.git.noring@nocrew.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2018-11/txt/msg00471.txt.bz2 Hello global GCC reviewers, Would it be possible to apply the reviewed patch below? Thank you, Fredrik On Fri, Oct 19, 2018 at 08:33:33PM +0200, Fredrik Noring wrote: > The Linux kernel requires and emulates LL and SC for the R5900 too. The > special --without-llsc default for the R5900 is therefore not applicable > in that case. > > Reviewed-by: Maciej W. Rozycki > --- > Changes in v2: > - Double spacing instead of single spacing in commit message > > --- > gcc/config.gcc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gcc/config.gcc b/gcc/config.gcc > index 720e6a7373d..68c34b16123 100644 > --- a/gcc/config.gcc > +++ b/gcc/config.gcc > @@ -3711,14 +3711,14 @@ fi > # Infer a default setting for --with-llsc. > if test x$with_llsc = x; then > case ${target} in > - mips64r5900-*-* | mips64r5900el-*-* | mipsr5900-*-* | mipsr5900el-*-*) > - # The R5900 doesn't support LL(D) and SC(D). > - with_llsc=no > - ;; > mips*-*-linux*) > # The kernel emulates LL and SC where necessary. > with_llsc=yes > ;; > + mips64r5900-*-* | mips64r5900el-*-* | mipsr5900-*-* | mipsr5900el-*-*) > + # The R5900 doesn't support LL(D) and SC(D). > + with_llsc=no > + ;; > esac > fi > > -- > 2.18.1 >