public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Marek Polacek <polacek@redhat.com>
To: Umesh Kalappa <umesh.kalappa0@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Bug 52869 - [DR 1207] "this" not being allowed in noexcept clauses
Date: Tue, 13 Nov 2018 15:40:00 -0000	[thread overview]
Message-ID: <20181113154008.GE28582@redhat.com> (raw)
In-Reply-To: <CAGfacvSOU6P5v1-muzPGyaZip9qzChjSLkwNKhYWmmofEgx+tA@mail.gmail.com>

On Tue, Nov 13, 2018 at 11:49:55AM +0530, Umesh Kalappa wrote:
> Hi All,
> 
> the following patch fix the subjected issue
> 
> Index: gcc/cp/parser.c
> ===================================================================
> --- gcc/cp/parser.c     (revision 266026)
> +++ gcc/cp/parser.c     (working copy)
> @@ -24615,6 +24615,8 @@
>      {
>        tree expr;
>        cp_lexer_consume_token (parser->lexer);
> +
> +      inject_this_parameter (current_class_type, TYPE_UNQUALIFIED);
> 
>        if (cp_lexer_peek_token (parser->lexer)->type == CPP_OPEN_PAREN)
>         {
> 
> 
> ok to commit along the testcase with changelog update ?

Thanks for the patch.

Please also include the testcase along with the patch (and I think it should
also test noexcept in a template).  Please also include a ChangeLog entry
in the patch submission.

Can you describe how this patch has been tested?

Further, wouldn't it be better to call inject_this_parameter inside the
CPP_OPEN_PAREN block?  If noexcept doesn't have any expression, then it
can't refer to "this".

Marek

  reply	other threads:[~2018-11-13 15:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13  6:20 Umesh Kalappa
2018-11-13 15:40 ` Marek Polacek [this message]
2018-11-13 21:25   ` Jason Merrill
2018-11-14 11:49     ` Umesh Kalappa
2018-11-14 13:23       ` Umesh Kalappa
2018-11-14 14:33       ` Marek Polacek
2018-11-14 16:25         ` Umesh Kalappa
2018-11-14 18:53           ` Marek Polacek
2018-11-15  8:56             ` Umesh Kalappa
2018-11-15 15:56               ` Marek Polacek
2018-11-15 15:59                 ` Marek Polacek
2018-11-16  6:53                 ` Umesh Kalappa
2018-11-16 18:18                   ` Marek Polacek
2018-11-16 21:55                     ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181113154008.GE28582@redhat.com \
    --to=polacek@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=umesh.kalappa0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).