From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84875 invoked by alias); 13 Nov 2018 20:19:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 84823 invoked by uid 89); 13 Nov 2018 20:19:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: one.firstfloor.org Received: from one.firstfloor.org (HELO one.firstfloor.org) (193.170.194.197) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Nov 2018 20:19:11 +0000 Received: by one.firstfloor.org (Postfix, from userid 503) id B916986951; Tue, 13 Nov 2018 21:19:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=firstfloor.org; s=mail; t=1542140348; bh=0e/D/RJ0j2h5h7jPqUGZ9uVeIkESxQiW055wek6JasM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qByZbzP2KGmPL3l9Ow/tfXHkxpyL+4oJ81VJjI7cLqFX9fULetghBD2Cl5aPLhCBa AMhAAlbZ+4h3gCKtIKZWYzzfpnnDXo/YaZuWIF5LIFYokiuCRJatLUwHK9E2AGaFTP DVF/sebkszQsvk3tYE73NTnxpwgD8wQSmBFWrT58= Date: Tue, 13 Nov 2018 20:19:00 -0000 From: Andi Kleen To: Richard Biener Cc: Andi Kleen , Andi Kleen , GCC Patches Subject: Re: [PATCH 2/3] Add a pass to automatically add ptwrite instrumentation Message-ID: <20181113201908.3jecodpkyuie76k3@two.firstfloor.org> References: <20181104063235.6914-1-andi@firstfloor.org> <20181104063235.6914-2-andi@firstfloor.org> <20181109181837.GB6218@tassilo.jf.intel.com> <20181112031610.GF6218@tassilo.jf.intel.com> <20181113180915.skcqes73spiruooa@two.firstfloor.org> <09B38DAB-F70B-4DFB-8BA2-4F5774A11753@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09B38DAB-F70B-4DFB-8BA2-4F5774A11753@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-11/txt/msg01147.txt.bz2 On Tue, Nov 13, 2018 at 07:37:27PM +0100, Richard Biener wrote: > I'd look at doing the instrumentation after var-tracking has run - that is what computes the locations in the end. That means instrumenting on late RTL after register allocation (and eventually with branch range restrictions in place). Basically you'd instrument at the same time as generating debug info. Ok that would be a full rewrite. I'll check if it's really a problem first. I would prefer to stay on the GIMPLE level. -Andi