From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120789 invoked by alias); 19 Nov 2018 22:26:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 119496 invoked by uid 89); 19 Nov 2018 22:24:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:562 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Nov 2018 22:24:42 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CDD95C3273; Mon, 19 Nov 2018 22:24:40 +0000 (UTC) Received: from redhat.com (unknown [10.20.4.212]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D29F1019634; Mon, 19 Nov 2018 22:24:40 +0000 (UTC) Date: Mon, 19 Nov 2018 22:26:00 -0000 From: Marek Polacek To: Paolo Carlini Cc: "gcc-patches@gcc.gnu.org" , Jason Merrill Subject: Re: [C++ Patch] PR 84636 ("internal compiler error: Segmentation fault (identifier_p()/grokdeclarator())") Message-ID: <20181119222438.GZ28582@redhat.com> References: <7e0b3ae8-3c74-f2a3-29f3-351b1d105a4b@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7e0b3ae8-3c74-f2a3-29f3-351b1d105a4b@oracle.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2018-11/txt/msg01666.txt.bz2 On Mon, Nov 19, 2018 at 08:03:24PM +0100, Paolo Carlini wrote: > @@ -12245,8 +12246,9 @@ grokdeclarator (const cp_declarator *declarator, > error ("invalid use of %<::%>"); > return error_mark_node; > } > - else if (TREE_CODE (type) == FUNCTION_TYPE > - || TREE_CODE (type) == METHOD_TYPE) > + else if ((TREE_CODE (type) == FUNCTION_TYPE > + || TREE_CODE (type) == METHOD_TYPE) I know it's preexisting but we have FUNC_OR_METHOD_TYPE_P for this. Marek