From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12810 invoked by alias); 20 Nov 2018 15:59:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12795 invoked by uid 89); 20 Nov 2018 15:59:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Nov 2018 15:59:32 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id wAKFxMsp031368; Tue, 20 Nov 2018 09:59:27 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id wAKFxKSS031363; Tue, 20 Nov 2018 09:59:20 -0600 Date: Tue, 20 Nov 2018 15:59:00 -0000 From: Segher Boessenkool To: Alan Modra Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 1/6] [RS6000] rs6000_call_template for external call insn assembly output Message-ID: <20181120155919.GW23873@gate.crashing.org> References: <20181107053326.GM29482@bubble.grove.modra.org> <20181107053751.GO29482@bubble.grove.modra.org> <2c5b2155-b4ce-b95a-8848-121c4398fb67@linux.ibm.com> <20181113001424.GD29784@bubble.grove.modra.org> <20181113111407.GP23873@gate.crashing.org> <20181113124755.GQ29784@bubble.grove.modra.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181113124755.GQ29784@bubble.grove.modra.org> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg01733.txt.bz2 On Tue, Nov 13, 2018 at 11:17:55PM +1030, Alan Modra wrote: > Version 2. > > This is a first step in tidying rs6000 call patterns, in preparation > to support inline plt calls. Okay for trunk. Thanks for the patch, and for the rework! Segher > * config/rs6000/rs6000-protos.h (rs6000_call_template): Declare. > (rs6000_sibcall_template): Declare. > (macho_call_template): Rename from output_call. > * config/rs6000/rs6000.c (rs6000_call_template_1): New function. > (rs6000_call_template, rs6000_sibcall_template): Likewise. > (macho_call_template): Rename from output_call. > * config/rs6000/rs6000.md (tls_gd_aix, tls_gd_sysv), > (tls_gd_call_aix, tls_gd_call_sysv, tls_ld_aix, tls_ld_sysv), > (tls_ld_call_aix, tls_ld_call_sysv, call_nonlocal_sysv), > (call_nonlocal_sysv_secure, call_value_nonlocal_sysv), > (call_value_nonlocal_sysv_secure, call_nonlocal_aix), > (call_value_nonlocal_aix): Use rs6000_call_template and update > occurrences of output_call to macho_call_template. > (sibcall_nonlocal_sysv, sibcall_value_nonlocal_sysv, sibcall_aix), > (sibcall_value_aix): Use rs6000_sibcall_template.