From: Jakub Jelinek <jakub@redhat.com>
To: Martin Sebor <msebor@gmail.com>
Cc: "Gcc Patch List" <gcc-patches@gcc.gnu.org>,
"Martin Liška" <mliska@suse.cz>
Subject: Re: [PATCH/coding style] clarify pointers and operators
Date: Tue, 27 Nov 2018 12:58:00 -0000 [thread overview]
Message-ID: <20181127125757.GQ12380@tucnak> (raw)
In-Reply-To: <6bce0b3a-0b0d-f03f-5f92-e00156e63629@gmail.com>
On Mon, Nov 26, 2018 at 10:59:47AM -0700, Martin Sebor wrote:
> --- htdocs/codingconventions.html 30 Sep 2018 14:38:46 -0000 1.85
> +++ htdocs/codingconventions.html 26 Nov 2018 17:59:21 -0000
> @@ -803,12 +803,17 @@
> <td><code>- x</code></td>
> </tr><tr>
> <td class="left">cast</td>
> - <td class="right"><code>(foo) x</code></td>
> - <td><code>(foo)x</code></td>
> + <td class="right"><code>(type) x</code></td>
> + <td><code>(type)x</code></td>
> </tr><tr>
> - <td class="left">pointer dereference</td>
> - <td class="right"><code>*x</code></td>
> - <td><code>* x</code></td>
Why have you removed the pointer dereference case, rather than just added
the new cases and replaced foo with type for cast? We want people to write
*x rather than * x.
Jakub
next prev parent reply other threads:[~2018-11-27 12:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 17:59 Martin Sebor
2018-11-26 20:41 ` Jeff Law
2018-11-27 18:46 ` Segher Boessenkool
2018-11-27 22:44 ` Jeff Law
2018-11-27 12:50 ` Martin Liška
2018-11-27 12:58 ` Jakub Jelinek [this message]
2018-11-27 16:11 ` Martin Sebor
2018-11-28 5:20 ` Sandra Loosemore
2018-11-28 23:40 ` Martin Sebor
2018-12-05 10:05 ` Richard Sandiford
2018-12-05 17:37 ` Segher Boessenkool
2018-12-05 18:03 ` Segher Boessenkool
2018-12-05 18:04 ` Martin Sebor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127125757.GQ12380@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).