From: Segher Boessenkool <segher@kernel.crashing.org>
To: Jeff Law <law@redhat.com>
Cc: "Martin Sebor" <msebor@gmail.com>,
"Gcc Patch List" <gcc-patches@gcc.gnu.org>,
"Martin Liška" <mliska@suse.cz>
Subject: Re: [PATCH/coding style] clarify pointers and operators
Date: Tue, 27 Nov 2018 18:46:00 -0000 [thread overview]
Message-ID: <20181127184630.GA23873@gate.crashing.org> (raw)
In-Reply-To: <bb0ada4b-9b46-7189-9109-489b6c09d83a@redhat.com>
On Mon, Nov 26, 2018 at 01:41:07PM -0700, Jeff Law wrote:
> On 11/26/18 10:59 AM, Martin Sebor wrote:
> > As an aside, regarding the space convention in casts: a crude
> > grep search yields about 10,000 instances of the "(type)x" kinds
> > of casts in GCC sources and 40,000 of the preferred "(type) x"
> > style with the space. That's a consistency of only 80%. Is
> > it worth documenting a preference for a convention that's so
> > inconsistently followed?
> Please do. It's a fairly recent change -- I suspect some old code was
> never fixed and some folks (perhaps myself) have that extraneous
> whitespace in their muscle memory and still need to eliminate it.
Huh? Spaces after casts are required, and make things much more
readable. This isn't recent.
A lot of old code writes spaces after single-character unary operators,
too, which is ugly and less readable. It's not recent that this is
explicitly documented as wrong, either.
Segher
next prev parent reply other threads:[~2018-11-27 18:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 17:59 Martin Sebor
2018-11-26 20:41 ` Jeff Law
2018-11-27 18:46 ` Segher Boessenkool [this message]
2018-11-27 22:44 ` Jeff Law
2018-11-27 12:50 ` Martin Liška
2018-11-27 12:58 ` Jakub Jelinek
2018-11-27 16:11 ` Martin Sebor
2018-11-28 5:20 ` Sandra Loosemore
2018-11-28 23:40 ` Martin Sebor
2018-12-05 10:05 ` Richard Sandiford
2018-12-05 17:37 ` Segher Boessenkool
2018-12-05 18:03 ` Segher Boessenkool
2018-12-05 18:04 ` Martin Sebor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127184630.GA23873@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=mliska@suse.cz \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).