From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65335 invoked by alias); 27 Nov 2018 22:00:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 65193 invoked by uid 89); 27 Nov 2018 22:00:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Nov 2018 22:00:44 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A3F623D96D; Tue, 27 Nov 2018 22:00:42 +0000 (UTC) Received: from localhost (unknown [10.33.36.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3ED465C8BD; Tue, 27 Nov 2018 22:00:42 +0000 (UTC) Date: Tue, 27 Nov 2018 22:00:00 -0000 From: Jonathan Wakely To: =?iso-8859-1?Q?Fran=E7ois?= Dumont Cc: "libstdc++@gcc.gnu.org" , gcc-patches Subject: Re: Fix hashtable memory leak Message-ID: <20181127220041.GD809@redhat.com> References: <20181126121233.GR28365@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.2 (2017-12-15) X-SW-Source: 2018-11/txt/msg02245.txt.bz2 On 27/11/18 22:31 +0100, François Dumont wrote: >I eventually called the new method _M_assign_elements. Perfect. >And yes, tracker_allocator was enough. Great. >Committed on trunk for the moment. Great, thanks. Please note that GCC 7.4 RC1 is scheduled for this week: https://gcc.gnu.org/ml/gcc/2018-11/msg00118.html Will you be able to backport the simpler patch (without the refactoring to remove code duplication) to the branch before then? If not I can take care of it.