From: Jakub Jelinek <jakub@redhat.com>
To: Richard Earnshaw <richard.earnshaw@arm.com>,
James Greenhalgh <james.greenhalgh@arm.com>,
Marcus Shawcroft <marcus.shawcroft@arm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: [PATCH] Restore aarch64 support for asm ("# %a0" : : "i" (0)) (PR target/87598)
Date: Wed, 28 Nov 2018 23:31:00 -0000 [thread overview]
Message-ID: <20181128233132.GB12380@tucnak> (raw)
Hi!
As mentioned in the PR, aarch64 used to allow VOIDmode CONST_INTs
as %aN operands, but r255230 started ICEing on it and r257907 turned
that ICE into error (output_operand_lossage).
The following patch restores the previous behavior, by allowing such
CONST_INTs through. They will fail aarch64_classify_address a few lines
later and so aarch64_print_address_internal will return false and either
cause output_operand_lossage there, or if it is aarch64_print_address,
let the generic code handle the constant.
Bootstrapped/regtested on aarch64-linux on GCCFarm, ok for trunk?
2018-11-29 Jakub Jelinek <jakub@redhat.com>
PR target/87598
* config/aarch64/aarch64.c (aarch64_print_address_internal): Don't
call output_operand_lossage on VOIDmode CONST_INTs. After
output_operand_lossage do return false.
* gcc.target/aarch64/asm-5.c: New test.
--- gcc/config/aarch64/aarch64.c.jj 2018-11-26 22:21:24.891607602 +0100
+++ gcc/config/aarch64/aarch64.c 2018-11-27 14:16:48.586358824 +0100
@@ -7635,8 +7635,14 @@ aarch64_print_address_internal (FILE *f,
unsigned int size;
/* Check all addresses are Pmode - including ILP32. */
- if (GET_MODE (x) != Pmode)
- output_operand_lossage ("invalid address mode");
+ if (GET_MODE (x) != Pmode
+ && (GET_MODE (x) != VOIDmode
+ || !CONST_INT_P (x)
+ || trunc_int_for_mode (INTVAL (x), Pmode) != INTVAL (x)))
+ {
+ output_operand_lossage ("invalid address mode");
+ return false;
+ }
if (aarch64_classify_address (&addr, x, mode, true, type))
switch (addr.type)
--- gcc/testsuite/gcc.target/aarch64/asm-5.c.jj 2018-11-27 14:24:18.774957407 +0100
+++ gcc/testsuite/gcc.target/aarch64/asm-5.c 2018-11-27 14:19:01.290176187 +0100
@@ -0,0 +1,8 @@
+/* PR target/87598 */
+/* { dg-do compile } */
+
+void
+foo (void)
+{
+ __asm__ ("# %a0" : : "i" (0));
+}
Jakub
next reply other threads:[~2018-11-28 23:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 23:31 Jakub Jelinek [this message]
2018-12-06 10:56 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128233132.GB12380@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=james.greenhalgh@arm.com \
--cc=marcus.shawcroft@arm.com \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).