public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Ed Smith-Rowland <3dw4rd@verizon.net>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>,
	Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH, libstdc++] Uniform container erasure for c++20.
Date: Thu, 29 Nov 2018 14:09:00 -0000	[thread overview]
Message-ID: <20181129140913.GT809@redhat.com> (raw)
In-Reply-To: <d1ea4c68-4971-ace4-093e-86163ed06962@verizon.net>

On 29/11/18 08:47 -0500, Ed Smith-Rowland wrote:
>Fixed with 266616.

Thanks!

>Index: include/std/deque
>===================================================================
>--- include/std/deque	(revision 266567)
>+++ include/std/deque	(working copy)
>@@ -58,6 +58,7 @@
> #pragma GCC system_header
>
> #include <bits/stl_algobase.h>
>+#include <bits/stl_algo.h> // For remove and remove_if

Please only include <bits/stl_algo.h> when __cplusplus > 201703L
otherwise we include hundreds of kilobytes of code just for these tiny
functions that aren't even defined in the default C++14 dialect.

At some point I'll split std::remove and std::remove_if into their own
header, and we can just include that instead.

  reply	other threads:[~2018-11-29 14:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-24 18:55 Ed Smith-Rowland
2018-11-26 11:18 ` Jonathan Wakely
2018-11-28 17:12   ` Ed Smith-Rowland
2018-11-29  0:25     ` Jonathan Wakely
2018-11-29 13:47       ` Ed Smith-Rowland
2018-11-29 14:09         ` Jonathan Wakely [this message]
2018-11-29 15:19           ` Ed Smith-Rowland
2018-11-29 16:32             ` Jonathan Wakely
2018-11-29 14:12         ` Jakub Jelinek
2018-11-29 17:06   ` Ed Smith-Rowland
2018-11-30  0:05     ` [PATCH, libstdc++] Uniform container erasure for c++20 returning number of erasures Ed Smith-Rowland
2018-11-30 10:25     ` [PATCH, libstdc++] Uniform container erasure for c++20 Jonathan Wakely
2018-11-30 10:41       ` Ville Voutilainen
2018-11-30 11:01         ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129140913.GT809@redhat.com \
    --to=jwakely@redhat.com \
    --cc=3dw4rd@verizon.net \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).