From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-491276-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 53434 invoked by alias); 29 Nov 2018 17:26:59 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 53407 invoked by uid 89); 29 Nov 2018 17:26:58 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=throw, Hx-languages-length:929, day
X-HELO: gate.crashing.org
Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Nov 2018 17:26:57 +0000
Received: from gate.crashing.org (localhost.localdomain [127.0.0.1])	by gate.crashing.org (8.14.1/8.14.1) with ESMTP id wATHQnjl001219;	Thu, 29 Nov 2018 11:26:50 -0600
Received: (from segher@localhost)	by gate.crashing.org (8.14.1/8.14.1/Submit) id wATHQlgY001215;	Thu, 29 Nov 2018 11:26:47 -0600
Date: Thu, 29 Nov 2018 17:26:00 -0000
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Peter Bergner <bergner@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,        Michael Meissner <meissner@linux.ibm.com>
Subject: Re: [PATCH, rs6000] Fix PR87496: ICE in aggregate_value_p at gcc/function.c:2046
Message-ID: <20181129172645.GD23873@gate.crashing.org>
References: <fbedc7ce-d1f1-4adf-ff4c-4c0401daa18b@linux.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fbedc7ce-d1f1-4adf-ff4c-4c0401daa18b@linux.ibm.com>
User-Agent: Mutt/1.4.2.3i
X-IsSubscribed: yes
X-SW-Source: 2018-11/txt/msg02478.txt.bz2

On Wed, Nov 28, 2018 at 03:27:19PM -0600, Peter Bergner wrote:
> PR87496 shows a bug where we ICE if we attempt to use -mabi=ieeelongdouble
> and -mno-popcntd.  The IEEE128 support requires full ISA 2.06 (aka POWER7)
> support, so we really should throw an error when using those options
> together.  Ditto for -mabi=ieeelongdouble and -mno-vsx.  The patch below
> does that.
> 
> Ok for mainline once bootstrap and regtesting are complete and clean?

Okay.  Eventually we shouldn't allow selecting popcntd independently from
-mcpu=, but that day isn't here yet.  So, okay for trunk, and backports
if wanted.  Thanks!


Segher


> 	PR target/87496
> 	* config/rs6000/rs6000.c (rs6000_option_override_internal): Disallow
> 	-mabi=ieeelongdouble without both -mpopcntd and -mvsx.
> 
> gcc/testsuite/
> 	PR target/87496
> 	* gcc.target/powerpc/pr87496.c: New test.