public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Andi Kleen <andi@firstfloor.org>
Cc: Andi Kleen <ak@linux.intel.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PING^3] Re: [PATCH 1/3] Support instrumenting returns of instrumented functions
Date: Thu, 29 Nov 2018 22:31:00 -0000	[thread overview]
Message-ID: <20181129223054.c6y7pwywa4dk56g4@kam.mff.cuni.cz> (raw)
In-Reply-To: <20181128204748.lrruhyrbmgynao4p@two.firstfloor.org>

> 
> I don't think it is because the instrumentation only adds calls, and
> calls don't get annotated in DWARF. The only issue I could think of
> if is something patches in push instructions through the nops, 
> but there is really nothing the compiler could do about that.
> 
> I tested gdb and it can backtrace through the return instrumentation.
> 
> Breakpoint 1, 0x0000000000401182 in __return__ ()
> (gdb) bt
> #0  0x0000000000401182 in __return__ ()
> #1  0x00000000004011a3 in f2 ()
> #2  0x00000000004011b7 in main ()
> Backtrace stopped: previous frame inner to this frame (corrupt stack?)

:) Not most user friendly message though.
The patch is OK.

Honza
> 
> -Andi

  reply	other threads:[~2018-11-29 22:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05  0:02 Andi Kleen
2018-11-05  0:02 ` [PATCH 2/3] Support changing fentry name per function Andi Kleen
2018-11-05  0:02   ` [PATCH 3/3] Allow changing the fentry section per file and " Andi Kleen
2018-11-08 17:11 ` [PING] Re: [PATCH 1/3] Support instrumenting returns of instrumented functions Andi Kleen
2018-11-15 19:03   ` [PING^2] " Andi Kleen
2018-11-21 20:48     ` [PING^3] " Andi Kleen
2018-11-28 15:59       ` Jan Hubicka
2018-11-28 16:11         ` Andi Kleen
2018-11-28 16:24           ` Jan Hubicka
2018-11-28 20:47             ` Andi Kleen
2018-11-29 22:31               ` Jan Hubicka [this message]
2018-12-02 16:26 Dominique d'Humières
2018-12-02 21:11 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129223054.c6y7pwywa4dk56g4@kam.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).