From: Jakub Jelinek <jakub@redhat.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org, arnd@linaro.org
Subject: Re: [PATCH] Come up with --param asan-stack-small-redzone (PR sanitizer/81715).
Date: Fri, 30 Nov 2018 12:01:00 -0000 [thread overview]
Message-ID: <20181130120057.GZ12380@tucnak> (raw)
In-Reply-To: <76d386fe-68a5-068c-111c-d3d5dc7a8b32@suse.cz>
On Fri, Nov 30, 2018 at 12:44:04PM +0100, Martin Liška wrote:
> Ok, I'm sending updated version of the patch. I factored out the shadow memory
> byte emission into a class, it's responsible for underlying flushing and guarantees
> that stores are 4B aligned (when beginning of stack vars is properly aligned
> to ASAN_RED_ZONE_SIZE).
>
> So far I tested the patch on x86_64-linux-gnu and ppc64le-linux-gnu machine.
Can you please do a bootstrap-asan too at least on the former to test it
some more?
Ok for trunk if that succeeds or doesn't regress compared to without this patch.
Thanks.
> 2018-11-30 Martin Liska <mliska@suse.cz>
>
> PR sanitizer/81715
> * asan.c (asan_shadow_cst): Remove, partially transform
> into flush_redzone_payload.
> (RZ_BUFFER_SIZE): New.
> (struct asan_redzone_buffer): New.
> (asan_redzone_buffer::emit_redzone_byte): Likewise.
> (asan_redzone_buffer::flush_redzone_payload): Likewise.
> (asan_redzone_buffer::flush_if_full): Likewise.
> (asan_emit_stack_protection): Use asan_redzone_buffer class
> that is responsible for proper aligned stores and flushing
> of shadow memory payload.
> * asan.h (ASAN_MIN_RED_ZONE_SIZE): New.
> (asan_var_and_redzone_size): Likewise.
> * cfgexpand.c (expand_stack_vars): Use smaller alignment
> (ASAN_MIN_RED_ZONE_SIZE) in order to make shadow memory
> for automatic variables more compact.
>
> gcc/testsuite/ChangeLog:
>
> 2018-11-30 Martin Liska <mliska@suse.cz>
>
> PR sanitizer/81715
> * c-c++-common/asan/asan-stack-small.c: New test.
Jakub
next prev parent reply other threads:[~2018-11-30 12:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 9:05 Martin Liška
2018-09-25 9:49 ` Jakub Jelinek
2018-09-25 10:17 ` Martin Liška
2018-09-25 10:25 ` Martin Liška
2018-09-25 12:19 ` Jakub Jelinek
2018-09-25 15:40 ` Martin Liška
2018-09-25 15:55 ` Jakub Jelinek
2018-09-26 9:34 ` Martin Liška
2018-10-09 8:53 ` Martin Liška
2018-10-23 9:17 ` Martin Liška
2018-11-13 7:50 ` Martin Liška
2018-11-28 12:01 ` Jakub Jelinek
2018-11-29 15:03 ` Martin Liška
2018-11-29 15:17 ` Jakub Jelinek
2018-11-29 16:37 ` Martin Liška
2018-11-29 16:50 ` Jakub Jelinek
2018-11-30 11:44 ` Martin Liška
2018-11-30 12:01 ` Jakub Jelinek [this message]
2018-12-01 7:36 ` [PATCH] Partial fix for asan on big endian targets (PR sanitizer/88289) Jakub Jelinek
2018-12-02 12:46 ` [committed] Fix ICE in asan_clear_shadow (PR sanitizer/88291) Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130120057.GZ12380@tucnak \
--to=jakub@redhat.com \
--cc=arnd@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).