From: Jakub Jelinek <jakub@redhat.com>
To: Julian Brown <julian@codesourcery.com>
Cc: Joseph Myers <joseph@codesourcery.com>,
Cesar Philippidis <cesar@codesourcery.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Tom de Vries <tdevries@suse.de>
Subject: Re: [patch,openacc] Fix infinite recursion in OMP clause pretty-printing, default label
Date: Fri, 30 Nov 2018 21:40:00 -0000 [thread overview]
Message-ID: <20181130214031.GK12380@tucnak> (raw)
In-Reply-To: <20181130213545.2cf83b69@squid.athome>
On Fri, Nov 30, 2018 at 09:35:45PM +0000, Julian Brown wrote:
> How's this? (Obvious, but re-tested anyway.)
>
> Thanks,
>
> Julian
>
> ChangeLog
>
> gcc/
> * tree-pretty-print.c (dump_omp_clause): Make default case
> gcc_unreachable.
Ok, thanks.
> diff --git a/gcc/tree-pretty-print.c b/gcc/tree-pretty-print.c
> index 99eca4a..0861cc9 100644
> --- a/gcc/tree-pretty-print.c
> +++ b/gcc/tree-pretty-print.c
> @@ -1180,9 +1180,7 @@ dump_omp_clause (pretty_printer *pp, tree clause, int spc, dump_flags_t flags)
> break;
>
> default:
> - /* Should never happen. */
> - dump_generic_node (pp, clause, spc, flags, false);
> - break;
> + gcc_unreachable ();
> }
> }
>
Jakub
next prev parent reply other threads:[~2018-11-30 21:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 17:10 Cesar Philippidis
2018-11-29 21:20 ` Julian Brown
2018-11-29 21:25 ` Joseph Myers
2018-11-30 21:35 ` Julian Brown
2018-11-30 21:40 ` Jakub Jelinek [this message]
2018-11-30 21:56 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130214031.GK12380@tucnak \
--to=jakub@redhat.com \
--cc=cesar@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=julian@codesourcery.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).