From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-491489-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 74407 invoked by alias); 3 Dec 2018 09:59:28 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 74398 invoked by uid 89); 3 Dec 2018 09:59:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=(unknown), Hx-languages-length:531
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Dec 2018 09:59:26 +0000
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 2ECDD308A958;	Mon,  3 Dec 2018 09:59:25 +0000 (UTC)
Received: from tucnak.zalov.cz (ovpn-117-214.ams2.redhat.com [10.36.117.214])	by smtp.corp.redhat.com (Postfix) with ESMTPS id C2D915D738;	Mon,  3 Dec 2018 09:59:24 +0000 (UTC)
Received: from tucnak.zalov.cz (localhost [127.0.0.1])	by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id wB39xMmk018674;	Mon, 3 Dec 2018 10:59:22 +0100
Received: (from jakub@localhost)	by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id wB39xJDt018673;	Mon, 3 Dec 2018 10:59:19 +0100
Date: Mon, 03 Dec 2018 09:59:00 -0000
From: Jakub Jelinek <jakub@redhat.com>
To: Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Cc: James Greenhalgh <James.Greenhalgh@arm.com>,        Richard Earnshaw <Richard.Earnshaw@arm.com>,        Marcus Shawcroft <Marcus.Shawcroft@arm.com>,        "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,        Ard Biesheuvel <ard.biesheuvel@linaro.org>,        Will Deacon <Will.Deacon@arm.com>, Mark Rutland <Mark.Rutland@arm.com>,        nd <nd@arm.com>
Subject: Re: [RFC][AArch64] Add support for system register based stack protector canary access
Message-ID: <20181203095919.GT12380@tucnak>
Reply-To: Jakub Jelinek <jakub@redhat.com>
References: <7a5a57fa-629d-d2ff-6292-e0893647ec8a@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7a5a57fa-629d-d2ff-6292-e0893647ec8a@arm.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-IsSubscribed: yes
X-SW-Source: 2018-12/txt/msg00063.txt.bz2

On Mon, Dec 03, 2018 at 09:55:36AM +0000, Ramana Radhakrishnan wrote:
> +  if (aarch64_stack_protector_guard == SSP_GLOBAL
> +      && opts->x_aarch64_stack_protector_guard_offset_str)
> +    {
> +      error ("Incompatible options -mstack-protector-guard=global and"

Diagnostic messages shouldn't start with capital letters (3 times in the
patch), unless it is something that is capitalized always, even in the
middle of sentences (say GNU etc.).

	Jakub