From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65413 invoked by alias); 4 Dec 2018 00:07:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 65393 invoked by uid 89); 4 Dec 2018 00:07:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=workers, independence, 201807, 2018-07 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Dec 2018 00:07:51 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-04.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1gTyFg-0004XG-GT from Julian_Brown@mentor.com for gcc-patches@gcc.gnu.org; Mon, 03 Dec 2018 16:07:48 -0800 Received: from squid.athome (137.202.0.90) by SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 4 Dec 2018 00:07:44 +0000 Date: Tue, 04 Dec 2018 00:07:00 -0000 From: Julian Brown To: Cesar Philippidis CC: "gcc-patches@gcc.gnu.org" , "Schwinge, Thomas" Subject: Re: [patch,opencc] Don't mark OpenACC auto loops as independent inside acc parallel regions Message-ID: <20181204000741.63685cd7@squid.athome> In-Reply-To: <4035f554-768f-2b88-c1a0-374972f168db@codesourcery.com> References: <4035f554-768f-2b88-c1a0-374972f168db@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00142.txt.bz2 On Thu, 20 Sep 2018 09:49:43 -0700 Cesar Philippidis wrote: > OpenACC as a concept of loop independence, in which independent loops > may be executed in parallel across gangs, workers and vectors. Inside > acc parallel regions, if a loop isn't explicitly marked seq or auto, > it is predetermined to be independent. > > This patch corrects a bug where acc loops marked as auto were being > mistakenly promoted to independent. That's bad because it can generate > bogus results if a dependency exist. > > Note that this patch depends on the following patches for > -fnote-info-omp-optimized which is used in a test case. > > * Add user-friendly OpenACC diagnostics regarding detected > parallelism. > https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01652.html > > * Correct the reported line number in fortran combined OpenACC > directives > https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01554.html > > * Correct the reported line number in c++ combined OpenACC > directives https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01552.html > > Is this OK for trunk? I bootstrapped and regtested on x86_64 Linux > with nvptx offloading. LGTM, FWIW. Thanks, Julian