From: Jakub Jelinek <jakub@redhat.com>
To: Jason Merrill <jason@redhat.com>, Marek Polacek <polacek@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: [PATCH] Fix P0634R3 - Down with typename! testsuite fallout
Date: Tue, 04 Dec 2018 08:43:00 -0000 [thread overview]
Message-ID: <20181204084251.GF12380@tucnak> (raw)
Hi!
I've noticed these two tests now FAIL with -std=c++2a, they don't print
any diagnostics. As I believe that was the point of the P0634R3 changes,
this patch adjusts the testcases. Tested on x86_64-linux, ok for trunk?
2018-12-04 Jakub Jelinek <jakub@redhat.com>
* g++.old-deja/g++.oliva/typename1.C: Don't expect any diagnostics
for C++2a.
* g++.old-deja/g++.oliva/typename2.C: Likewise.
--- gcc/testsuite/g++.old-deja/g++.oliva/typename1.C.jj 2008-09-05 12:54:51.000000000 +0200
+++ gcc/testsuite/g++.old-deja/g++.oliva/typename1.C 2018-12-04 09:36:46.137087008 +0100
@@ -12,5 +12,5 @@ template <class T> struct bar {
};
template <class T> struct baz {
- typedef bar<T>::foo foo; // { dg-error "" } missing typename
+ typedef bar<T>::foo foo; // { dg-error "need 'typename' before" "" { target c++17_down } }
};
--- gcc/testsuite/g++.old-deja/g++.oliva/typename2.C.jj 2008-09-05 12:54:51.000000000 +0200
+++ gcc/testsuite/g++.old-deja/g++.oliva/typename2.C 2018-12-04 09:37:27.069419970 +0100
@@ -23,6 +23,6 @@ template <class T> struct bar {
};
template <class T> struct baz {
- typedef bar<T>::foo foo; // { dg-error "" } implicit typename
+ typedef bar<T>::foo foo; // { dg-error "need 'typename' before" "" { target c++17_down } }
void m(foo);
};
Jakub
next reply other threads:[~2018-12-04 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 8:43 Jakub Jelinek [this message]
2018-12-04 13:19 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204084251.GF12380@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).