* [PATCH] Fix P0634R3 - Down with typename! testsuite fallout
@ 2018-12-04 8:43 Jakub Jelinek
2018-12-04 13:19 ` Marek Polacek
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2018-12-04 8:43 UTC (permalink / raw)
To: Jason Merrill, Marek Polacek; +Cc: gcc-patches
Hi!
I've noticed these two tests now FAIL with -std=c++2a, they don't print
any diagnostics. As I believe that was the point of the P0634R3 changes,
this patch adjusts the testcases. Tested on x86_64-linux, ok for trunk?
2018-12-04 Jakub Jelinek <jakub@redhat.com>
* g++.old-deja/g++.oliva/typename1.C: Don't expect any diagnostics
for C++2a.
* g++.old-deja/g++.oliva/typename2.C: Likewise.
--- gcc/testsuite/g++.old-deja/g++.oliva/typename1.C.jj 2008-09-05 12:54:51.000000000 +0200
+++ gcc/testsuite/g++.old-deja/g++.oliva/typename1.C 2018-12-04 09:36:46.137087008 +0100
@@ -12,5 +12,5 @@ template <class T> struct bar {
};
template <class T> struct baz {
- typedef bar<T>::foo foo; // { dg-error "" } missing typename
+ typedef bar<T>::foo foo; // { dg-error "need 'typename' before" "" { target c++17_down } }
};
--- gcc/testsuite/g++.old-deja/g++.oliva/typename2.C.jj 2008-09-05 12:54:51.000000000 +0200
+++ gcc/testsuite/g++.old-deja/g++.oliva/typename2.C 2018-12-04 09:37:27.069419970 +0100
@@ -23,6 +23,6 @@ template <class T> struct bar {
};
template <class T> struct baz {
- typedef bar<T>::foo foo; // { dg-error "" } implicit typename
+ typedef bar<T>::foo foo; // { dg-error "need 'typename' before" "" { target c++17_down } }
void m(foo);
};
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix P0634R3 - Down with typename! testsuite fallout
2018-12-04 8:43 [PATCH] Fix P0634R3 - Down with typename! testsuite fallout Jakub Jelinek
@ 2018-12-04 13:19 ` Marek Polacek
0 siblings, 0 replies; 2+ messages in thread
From: Marek Polacek @ 2018-12-04 13:19 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Jason Merrill, gcc-patches
On Tue, Dec 04, 2018 at 09:42:51AM +0100, Jakub Jelinek wrote:
> Hi!
>
> I've noticed these two tests now FAIL with -std=c++2a, they don't print
> any diagnostics. As I believe that was the point of the P0634R3 changes,
> this patch adjusts the testcases. Tested on x86_64-linux, ok for trunk?
>
> 2018-12-04 Jakub Jelinek <jakub@redhat.com>
>
> * g++.old-deja/g++.oliva/typename1.C: Don't expect any diagnostics
> for C++2a.
> * g++.old-deja/g++.oliva/typename2.C: Likewise.
The patch is fine, sorry for missing that. Apparently I only ran c++2a
with dg.exp.
Marek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-04 13:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-04 8:43 [PATCH] Fix P0634R3 - Down with typename! testsuite fallout Jakub Jelinek
2018-12-04 13:19 ` Marek Polacek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).