From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12208 invoked by alias); 4 Dec 2018 12:29:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12178 invoked by uid 89); 4 Dec 2018 12:29:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=U*nathan X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Dec 2018 12:29:20 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BE24A3091747; Tue, 4 Dec 2018 12:29:18 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-117-214.ams2.redhat.com [10.36.117.214]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DAE0F1C92F; Tue, 4 Dec 2018 12:29:17 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id wB4CTFgn024443; Tue, 4 Dec 2018 13:29:16 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id wB4CTEEH024442; Tue, 4 Dec 2018 13:29:14 +0100 Date: Tue, 04 Dec 2018 12:29:00 -0000 From: Jakub Jelinek To: Cesar Philippidis , Thomas Schwinge , Tom de Vries Cc: "gcc-patches@gcc.gnu.org" Subject: Re: [patch] various OpenACC reduction enhancements - ME and nvptx changes Message-ID: <20181204122914.GK12380@tucnak> Reply-To: Jakub Jelinek References: <27100797-1930-5c5f-ec68-c5888be08088@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <27100797-1930-5c5f-ec68-c5888be08088@codesourcery.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00163.txt.bz2 On Fri, Jun 29, 2018 at 11:19:53AM -0700, Cesar Philippidis wrote: > The attached patch includes the nvptx and GCC ME reductions enhancements. > > Is this patch OK for trunk? It bootstrapped / regression tested cleanly > for x86_64 with nvptx offloading. This is all OpenACC specific code not really shareable with OpenMP, if Thomas (for middle-end) and Tom (for NVPTX backend) are ok with it, it is ok for trunk. > 2018-06-29 Cesar Philippidis > Nathan Sidwell > > gcc/ > * config/nvptx/nvptx.c (nvptx_propagate_unified): New. > (nvptx_split_blocks): Call it for cond_uni insn. > (nvptx_expand_cond_uni): New. > (enum nvptx_builtins): Add NVPTX_BUILTIN_COND_UNI. > (nvptx_init_builtins): Initialize it. > (nvptx_expand_builtin): > (nvptx_generate_vector_shuffle): Change integral SHIFT operand to > tree BITS operand. > (nvptx_vector_reduction): New. > (nvptx_adjust_reduction_type): New. > (nvptx_goacc_reduction_setup): Use it to adjust the type of ref_to_res. > (nvptx_goacc_reduction_init): Don't update LHS if it doesn't exist. > (nvptx_goacc_reduction_fini): Call nvptx_vector_reduction for vector. > Use it to adjust the type of ref_to_res. > (nvptx_goacc_reduction_teardown): > * config/nvptx/nvptx.md (cond_uni): New pattern. > * omp-general.h (enum oacc_loop_flags): Add OLF_REDUCTION enum. > * omp-low.c (lower_oacc_reductions): Handle reduction decls mapped > with GOMP_MAP_FIRSTPRIVATE_POINTER. > (lower_oacc_head_mark): Use OLF_REDUCTION to mark OpenACC reductions. > * omp-offload.c (oacc_loop_auto_partitions): Don't assign gang > level parallelism to orphan reductions. > (default_goacc_reduction): Retype ref_to_res as necessary. Jakub