From: Segher Boessenkool <segher@kernel.crashing.org>
To: Iain Sandoe <iain@sandoe.co.uk>
Cc: GCC-patches <gcc-patches@gcc.gnu.org>, Alan Modra <amodra@gmail.com>
Subject: Re: [Patch, ppc/darwin 2/2] Make Darwin's call handling follow the style of AIX/ELFv2/sysv.
Date: Tue, 04 Dec 2018 17:38:00 -0000 [thread overview]
Message-ID: <20181204173826.GF3803@gate.crashing.org> (raw)
In-Reply-To: <3F06E9FC-D02C-47D4-B223-523FA2EDEF4A@sandoe.co.uk>
On Mon, Dec 03, 2018 at 07:18:20PM +0000, Iain Sandoe wrote:
> revised version, on top of the revised patch 1 attached. Iâve taken the opportunity to reduce the number of TARGET_MACHO conditionals in rs6000.md (handle in rs6000.c instead)
> From 82ac030d49fd2ae78b75a350c5efc59375df42a6 Mon Sep 17 00:00:00 2001
> From: Iain Sandoe <iain@sandoe.co.uk>
> Date: Sat, 1 Dec 2018 16:23:20 +0000
> Subject: [PATCH] [darwin,ppc] Update call expansions to follow the new scheme.
>
> This also makes it a bit more apparent what we can remove when the
> mlongcall optimisation is removed.
> --- a/gcc/config/rs6000/rs6000.md
> +++ b/gcc/config/rs6000/rs6000.md
> @@ -10285,8 +10285,10 @@
>
> if (DEFAULT_ABI == ABI_AIX || DEFAULT_ABI == ABI_ELFv2)
> rs6000_call_aix (NULL_RTX, operands[0], operands[1], operands[2]);
> - else
> + else if (DEFAULT_ABI == ABI_V4)
> rs6000_call_sysv (NULL_RTX, operands[0], operands[1], operands[2]);
> + else
> + rs6000_call_darwin (NULL_RTX, operands[0], operands[1], operands[2]);
Maybe
else if (DEFAULT_ABI == ABI_DARWIN)
...
else
gcc_unreachable ();
? Similar elsewhere.
And I think I saw a missing space-before-opening-paren somewhere, but I
cannot find it now. Okay for trunk, anyhow.
Segher
prev parent reply other threads:[~2018-12-04 17:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 1:28 Iain Sandoe
2018-12-03 19:18 ` Iain Sandoe
2018-12-04 17:38 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204173826.GF3803@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=amodra@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).