public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH 0/3][rs6000] x86-compat vector intrinsics fixes for BE, 32bit
@ 2018-12-04 14:58 Paul Clarke
  2018-12-04 18:07 ` Segher Boessenkool
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Clarke @ 2018-12-04 14:58 UTC (permalink / raw)
  To: gcc-patches, Segher Boessenkool

Many of the tests for the x86-compatible vector intrinsics implementations
were protected by "#ifdef __BUILTIN_CPU_SUPPORTS__", which is only enabled
with recent enough glibc that in most environments, the test were silently
passing without actually testing anything.

Patches which follow:
01: Fix the implementations.
02: Fix the test cases.
03: Enable the tests to actually run the test code.

Bootstrap and regression tested on POWER8 ppc64le, ppc64(be), ppc(32bit be),
and POWER7 ppc64(be).

OK for trunk?

PC

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 0/3][rs6000] x86-compat vector intrinsics fixes for BE, 32bit
  2018-12-04 14:58 [PATCH 0/3][rs6000] x86-compat vector intrinsics fixes for BE, 32bit Paul Clarke
@ 2018-12-04 18:07 ` Segher Boessenkool
  0 siblings, 0 replies; 2+ messages in thread
From: Segher Boessenkool @ 2018-12-04 18:07 UTC (permalink / raw)
  To: Paul Clarke; +Cc: gcc-patches

On Tue, Dec 04, 2018 at 08:58:15AM -0600, Paul Clarke wrote:
> Many of the tests for the x86-compatible vector intrinsics implementations
> were protected by "#ifdef __BUILTIN_CPU_SUPPORTS__", which is only enabled
> with recent enough glibc that in most environments, the test were silently
> passing without actually testing anything.

And that will still be true for years to come.  Right.  Thanks for working
on this.

> Patches which follow:
> 01: Fix the implementations.
> 02: Fix the test cases.
> 03: Enable the tests to actually run the test code.

In the future, please thread the patches, so that all of them have
In-Reply-To: the 0/N patch.


Segher

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-04 18:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-04 14:58 [PATCH 0/3][rs6000] x86-compat vector intrinsics fixes for BE, 32bit Paul Clarke
2018-12-04 18:07 ` Segher Boessenkool

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).