From: Segher Boessenkool <segher@kernel.crashing.org>
To: Paul Clarke <pc@us.ibm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 2/3][rs6000] Fix x86-compat vector intrinsics testcases for BE, 32bit
Date: Tue, 04 Dec 2018 21:34:00 -0000 [thread overview]
Message-ID: <20181204213401.GJ3803@gate.crashing.org> (raw)
In-Reply-To: <bb71ef8b-72fe-f7b8-dbb5-07ad97249536@us.ibm.com>
Hi!
On Tue, Dec 04, 2018 at 08:59:40AM -0600, Paul Clarke wrote:
> Fix general endian issues found in the test cases for the compatibility
> implementations of the x86 vector intrinsics. (The tests had been
> inadvertently made to PASS without actually running the test code.
> A later patch fixes this issue.)
>
> Additionally, a new <smmintrin.h> is added, as some of the APIs therein are
> now used by the test cases. It is _not_ a complete implementation of the
> SSE4 interfaces, only the few "extract" interfaces uses by the tests.
Hrm. We probably should tell the user this file isn't the real thing,
somehow. Could you add a comment in (or near) the header of the file?
I don't think we'll need more, but we'll find out no doubt.
> PR target/88316
> * config/rs6000/smmintrin.h: New file.
> * config.gcc: add smmintrin.h to extra_headers for powerpc*-*-*.
(Capital A).
> [gcc/testsuite]
>
> PR target/88316
> * gcc.target/powerpc/mmx-packssdw-1.c: Fixes for big-endian.
> * gcc.target/powerpc/mmx-packsswb-1.c: Likewise.
> * gcc.target/powerpc/mmx-packuswb-1.c: Likewise.
> * gcc.target/powerpc/mmx-pmulhw-1.c: Likewise.
> * gcc.target/powerpc/sse-cvtpi32x2ps-1.c: Likewise.
> * gcc.target/powerpc/sse-cvtpu16ps-1.c: Likewise.
> * gcc.target/powerpc/sse-cvtss2si-1.c: Likewise.
> * gcc.target/powerpc/sse-cvtss2si-2.c: Likewise.
> * gcc.target/powerpc/sse2-pshufhw-1.c: Likewise.
> * gcc.target/powerpc/sse2-pshuflw-1.c: Likewise.
Okay for trunk with that. Thanks!
Segher
prev parent reply other threads:[~2018-12-04 21:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 14:59 Paul Clarke
2018-12-04 21:34 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204213401.GJ3803@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=pc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).