From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52351 invoked by alias); 4 Dec 2018 21:34:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 52293 invoked by uid 89); 4 Dec 2018 21:34:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Dec 2018 21:34:16 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id wB4LYAU9017966; Tue, 4 Dec 2018 15:34:10 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id wB4LY38V017959; Tue, 4 Dec 2018 15:34:03 -0600 Date: Tue, 04 Dec 2018 21:34:00 -0000 From: Segher Boessenkool To: Paul Clarke Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 2/3][rs6000] Fix x86-compat vector intrinsics testcases for BE, 32bit Message-ID: <20181204213401.GJ3803@gate.crashing.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00232.txt.bz2 Hi! On Tue, Dec 04, 2018 at 08:59:40AM -0600, Paul Clarke wrote: > Fix general endian issues found in the test cases for the compatibility > implementations of the x86 vector intrinsics. (The tests had been > inadvertently made to PASS without actually running the test code. > A later patch fixes this issue.) > > Additionally, a new is added, as some of the APIs therein are > now used by the test cases. It is _not_ a complete implementation of the > SSE4 interfaces, only the few "extract" interfaces uses by the tests. Hrm. We probably should tell the user this file isn't the real thing, somehow. Could you add a comment in (or near) the header of the file? I don't think we'll need more, but we'll find out no doubt. > PR target/88316 > * config/rs6000/smmintrin.h: New file. > * config.gcc: add smmintrin.h to extra_headers for powerpc*-*-*. (Capital A). > [gcc/testsuite] > > PR target/88316 > * gcc.target/powerpc/mmx-packssdw-1.c: Fixes for big-endian. > * gcc.target/powerpc/mmx-packsswb-1.c: Likewise. > * gcc.target/powerpc/mmx-packuswb-1.c: Likewise. > * gcc.target/powerpc/mmx-pmulhw-1.c: Likewise. > * gcc.target/powerpc/sse-cvtpi32x2ps-1.c: Likewise. > * gcc.target/powerpc/sse-cvtpu16ps-1.c: Likewise. > * gcc.target/powerpc/sse-cvtss2si-1.c: Likewise. > * gcc.target/powerpc/sse-cvtss2si-2.c: Likewise. > * gcc.target/powerpc/sse2-pshufhw-1.c: Likewise. > * gcc.target/powerpc/sse2-pshuflw-1.c: Likewise. Okay for trunk with that. Thanks! Segher