From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122317 invoked by alias); 4 Dec 2018 22:54:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 122292 invoked by uid 89); 4 Dec 2018 22:54:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy= X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Dec 2018 22:54:05 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id wB4Ms1Zp024653; Tue, 4 Dec 2018 16:54:02 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id wB4MrxBt024641; Tue, 4 Dec 2018 16:53:59 -0600 Date: Tue, 04 Dec 2018 22:54:00 -0000 From: Segher Boessenkool To: Peter Bergner Cc: GCC Patches , Michael Meissner Subject: Re: [PATCH, rs6000] Fix PR87496: ICE in aggregate_value_p at gcc/function.c:2046 Message-ID: <20181204225358.GM3803@gate.crashing.org> References: <7abf394f-35a8-08b6-4f7d-f00fd6663930@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7abf394f-35a8-08b6-4f7d-f00fd6663930@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00239.txt.bz2 On Tue, Dec 04, 2018 at 01:42:52PM -0600, Peter Bergner wrote: > On 11/28/18 3:27 PM, Peter Bergner wrote: > > gcc/ > > PR target/87496 > > * config/rs6000/rs6000.c (rs6000_option_override_internal): Disallow > > -mabi=ieeelongdouble without both -mpopcntd and -mvsx. > > So this "fix" ended up accidentally disallowing -mabi=ibmlongdouble as well, > which is wrong. I need to look at not only whether the variable > global_options_set.x_rs6000_ieeequad is set, which tells us whether we > used -mabi={ibm,ieee}longdouble, but whether we actually enabled ieee128. > The patch below fixes that oversight. As we talked offline, we also should > not allow either -mabi={ibm,ieee}longdouble with -mlong-double-64, since > they are conflicting options. I have added code to test for that as well. > I have also added extra test cases to test for those. Okay, so you make -mabi={ibm,ieee}longdouble be valid options only if there is -mlong-double-128. Could you add that to the documentation then please? > Is this ok for mainline once bootstrap and regtesting come back clean? Okay with that documentation added and if it tests okay, yes. Thanks! > Since I backported the earlier fix to GCC8, I'd like to backport this > there too. Okay for there too. Segher > gcc/ > PR target/87496 > * config/rs6000/rs6000.c (rs6000_option_override_internal): Disallow > -mabi=ieeelongdouble and -mabi=ibmlongdouble without -mlong-double-128. > Do not error for -mabi=ibmlongdouble and no ISA 2.06 support. > > gcc/testsuite/ > PR target/87496 > * gcc.target/powerpc/pr87496.c: Rename from this... > * gcc.target/powerpc/pr87496-1.c: ...to this. Update comment. > * gcc.target/powerpc/pr87496-2.c: New test. > * gcc.target/powerpc/pr87496-3.c: New test.