From: Segher Boessenkool <segher@kernel.crashing.org>
To: Iain Sandoe <iain@sandoe.co.uk>
Cc: GCC-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, PPC] Fix PR88343.
Date: Wed, 05 Dec 2018 18:12:00 -0000 [thread overview]
Message-ID: <20181205181158.GT3803@gate.crashing.org> (raw)
In-Reply-To: <40EA3BFC-C4F7-4CA0-9C65-19C47AA3C74D@sandoe.co.uk>
On Wed, Dec 05, 2018 at 05:10:07PM +0000, Iain Sandoe wrote:
> Hi,
>
> The PR is about unnecessary saves of the pic base register, it shows on m32 Linux and m32/m64 Darwin.
>
> The fix is to check that we are in a pic mode and that the picbase has actually been used.
> As a bonus, some #ifdef’d TARGET_MACHO code is no longer required.
>
> Tested on power7, bootstrapped on Darwin (testing continues).
>
> OK for trunk?
Okay for trunk if testing completes successfully :-) Thanks!
> Branches?
Sure. Please let is soak on trunk for a week first; and don't do 7
until 7.4 has been made?
> 2018-xx-xx Segher Boessenkool <segher@kernel.crashing.org>
> Iain Sandoe <iain@sandoe.co.uk>
>
> gcc/
> * config/rs6000/rs6000.c (save_reg_p): Do not save the picbase reg
> unless it has been used. (first_reg_to_save): Remove dead code.
Your changelogs still wrap (the second "(" should start a new line).
Segher
prev parent reply other threads:[~2018-12-05 18:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 17:10 Iain Sandoe
2018-12-05 18:12 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205181158.GT3803@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).