From: Segher Boessenkool <segher@kernel.crashing.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Joseph Myers <joseph@codesourcery.com>,
jason@redhat.com, nathan@acm.org, polacek@redhat.com
Subject: Re: [PATCH v2 0/2] asm qualifiers (PR55681) and asm inline
Date: Thu, 06 Dec 2018 18:54:00 -0000 [thread overview]
Message-ID: <20181206185408.GC3803@gate.crashing.org> (raw)
In-Reply-To: <20181206181520.GW12380@tucnak>
On Thu, Dec 06, 2018 at 07:15:20PM +0100, Jakub Jelinek wrote:
> On Thu, Dec 06, 2018 at 12:10:56PM -0600, Segher Boessenkool wrote:
> > On Sun, Dec 02, 2018 at 04:38:16PM +0000, Segher Boessenkool wrote:
> > > v2, with the input from Joseph taken into account.
> > >
> > > This is the same "asm inline" patch as before, but now preceded by a
> > > patch that makes all orderings of volatile/goto/inline valid, all other
> > > type qualifiers invalid, all repetitions of qualifiers invalid.
> >
> > Committed now, with everyone's suggestions addressed.
> >
> > Is this okay for backport to 8? Maybe 7? After a week or so, of course.
> > This will help the Linux people to use it sooner.
>
> Not sure if in the backport we shouldn't keep accepting with warning like
> before const asm and not do the changes of accepting in any order except
> perhaps for the inline keyword in there?
Okay, I'll edit the const (etc.) back in. The "any order" is easier to
keep this way I think (and doesn't change anything for code that was
already accepted).
Segher
prev parent reply other threads:[~2018-12-06 18:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-02 16:38 Segher Boessenkool
2018-12-02 16:39 ` [PATCH 1/2] asm qualifiers (PR55681) Segher Boessenkool
2018-12-03 22:20 ` Joseph Myers
2018-12-05 21:47 ` Jason Merrill
2018-12-05 23:02 ` Segher Boessenkool
2018-12-02 16:40 ` [PATCH 2/2] asm inline Segher Boessenkool
2018-12-02 17:23 ` Marc Glisse
2018-12-02 17:45 ` Segher Boessenkool
2018-12-02 18:38 ` Marc Glisse
2018-12-04 15:31 ` Richard Sandiford
2018-12-06 3:03 ` Segher Boessenkool
2018-12-06 18:11 ` [PATCH v2 0/2] asm qualifiers (PR55681) and " Segher Boessenkool
2018-12-06 18:15 ` Jakub Jelinek
2018-12-06 18:19 ` Joseph Myers
2018-12-06 18:54 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206185408.GC3803@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=nathan@acm.org \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).