From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Thomas Koenig <tkoenig@netcologne.de>
Cc: Fritz Reese <fritzoreese@gmail.com>,
fortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Fortran patches
Date: Thu, 06 Dec 2018 22:56:00 -0000 [thread overview]
Message-ID: <20181206225620.GA14703@troutmask.apl.washington.edu> (raw)
In-Reply-To: <a2683039-c88e-eea6-f8a8-f2b852f607bd@netcologne.de>
On Thu, Dec 06, 2018 at 08:02:43PM +0100, Thomas Koenig wrote:
> >>> PR fortran/88139
> >>> * dump-parse-tree.c (write_proc): Alternate return.
> >> I dissent with this patch. The introduced error is meaningless and, as
> >> mentioned by comment #3 in the PR, avoiding the ICE in dump-parse-tree
> >> is not directly the issue. The code should be rejected in parsing. In
> >> gcc-8.1 the invalid code is accepted (without an ICE) even without the
> >> -fc-prototypes flag: I haven't finished building the compiler with
> >> your changes yet to see whether that is still true afterwards, but at
> >> least the test case doesn't try this, so I strongly suspect the patch
> >> is incomplete to fix the PR.
> >
> > Comment #3 does not contain a patch to fix the problem elsewhere.
>
> I know :-)
>
> > In F2003, 15.2.6 "Interoperability of procedures and procedure interfaces",
> > I cannot find a prohibition on an alternate return in a subroutine
> > interface with BIND(C).
>
> I also does not allow this, and does not offer a valid interpretation
> of what it should mean.
>
> If it has a meaning, it should be translatable into something prescribed
> by the standard with -fc-prototypes.
>
> I have assigned the error to myself, so I will not forget to fix
> it before the gcc 9 release.
>
I have asked on c.l.f. It seems NAG rejects alternate return
mixed with bind(c). FortranFan provided a complete testcase:
subroutine foo(*) bind(C, name='f')
end subroutine foo
program p
interface
subroutine bar(*) bind(C, name='f')
end subroutine bar
end interface
call bar( *10 )
print *, "Return following 'bar' invocation: jumping to 20"
go to 20
10 print *, "THIS IS UNEXPECTED: Alternate return to 10 after bar"
20 continue
stop
end program p
NAG rejects it. Intel, PGI, and gfortran accept it.
--
Steve
next prev parent reply other threads:[~2018-12-06 22:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 4:59 Steve Kargl
2018-12-05 21:49 ` Fritz Reese
2018-12-06 0:03 ` Steve Kargl
2018-12-06 19:03 ` Thomas Koenig
2018-12-06 19:23 ` Steve Kargl
2018-12-06 22:56 ` Steve Kargl [this message]
2018-12-06 19:09 ` Fritz Reese
2018-12-06 19:51 ` Steve Kargl
2018-12-07 1:21 ` Steve Kargl
2018-12-07 1:49 ` Steve Kargl
-- strict thread matches above, loose matches on Subject: below --
2011-09-16 7:44 Fortran Patches Tobias Burnus
2011-09-16 8:14 ` Janus Weil
2011-09-17 13:31 ` Janus Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206225620.GA14703@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
--cc=fritzoreese@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).