From: Jakub Jelinek <jakub@redhat.com>
To: Jeff Law <law@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [committed] Add test for PR85770.
Date: Thu, 06 Dec 2018 23:40:00 -0000 [thread overview]
Message-ID: <20181206234010.GC12380@tucnak> (raw)
In-Reply-To: <6f5fb678-76c0-25c8-65b2-b6d3180fa054@redhat.com>
On Wed, Dec 05, 2018 at 05:41:49PM -0700, Jeff Law wrote:
>
> PR85770 is fixed by Segher's combiner patch to avoid combining hard
> regs. Presumably it helps because it gives the allocators more freedom.
>
> I'm adding the testcase from the PR to the regression suite.
>
> Jeff
> commit 40fc691eac0ea9414f7908826c91afc70ff78617
> Author: law <law@138bc75d-0d04-0410-961f-82ee72b054a4>
> Date: Thu Dec 6 00:40:08 2018 +0000
>
> PR rtl-optimization/85770
> * gcc.target/i386/pr85770.c: New test.
The test FAILs on i686-linux, because __int128 is not supported on 32-bit
targets.
Fixed thusly, tested on x86_64-linux and i686-linux, committed as obvious to
trunk.
2018-12-07 Jakub Jelinek <jakub@redhat.com>
PR rtl-optimization/85770
* gcc.target/i386/pr85770.c: Require int128 effective target.
--- gcc/testsuite/gcc.target/i386/pr85770.c (revision 266876)
+++ gcc/testsuite/gcc.target/i386/pr85770.c (working copy)
@@ -1,4 +1,5 @@
-/* { dg-do compile } */
+/* PR rtl-optimization/85770 */
+/* { dg-do compile { target int128 } } */
/* { dg-options "-O2 -march=nano-1000 -fnon-call-exceptions -fno-tree-coalesce-vars" } */
unsigned a, b, c, d, e, f, g, h, i;
@@ -14,4 +15,3 @@ __int128 foo(char k, unsigned short l, u
return k + l + m + n + o + a + b + c + d + j + l + e + f + q + 4294967295 +
p + g + h + i;
}
-
Jakub
prev parent reply other threads:[~2018-12-06 23:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 0:41 Jeff Law
2018-12-06 23:40 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206234010.GC12380@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).