* [Committed] PR fortran/88048 -- named constant can't be data object
@ 2018-12-09 6:31 Steve Kargl
0 siblings, 0 replies; only message in thread
From: Steve Kargl @ 2018-12-09 6:31 UTC (permalink / raw)
To: fortran, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 370 bytes --]
A named constant cannot be a data object. The committed
patch catches an instance that should be caught.
2018-12-08 Steven G. Kargl <kargl@gcc.gnu.org>
PR fortran/88048
* resolve.c (check_data_variable): Named constant cannot be a
data object.
2018-12-08 Steven G. Kargl <kargl@gcc.gnu.org>
PR fortran/88048
* gfortran.dg/pr88048.f90: New test.
--
Steve
[-- Attachment #2: z_pr88048.diff --]
[-- Type: text/x-diff, Size: 1214 bytes --]
Index: gcc/fortran/resolve.c
===================================================================
--- gcc/fortran/resolve.c (revision 266912)
+++ gcc/fortran/resolve.c (working copy)
@@ -15493,7 +15493,10 @@ check_data_variable (gfc_data_variable *var, locus *wh
e = e->value.function.actual->expr;
if (e->expr_type != EXPR_VARIABLE)
- gfc_internal_error ("check_data_variable(): Bad expression");
+ {
+ gfc_error ("Expecting definable entity near %L", where);
+ return false;
+ }
sym = e->symtree->n.sym;
@@ -15501,6 +15504,7 @@ check_data_variable (gfc_data_variable *var, locus *wh
{
gfc_error ("BLOCK DATA element %qs at %L must be in COMMON",
sym->name, &sym->declared_at);
+ return false;
}
if (e->ref == NULL && sym->as)
Index: gcc/testsuite/gfortran.dg/pr88048.f90
===================================================================
--- gcc/testsuite/gfortran.dg/pr88048.f90 (nonexistent)
+++ gcc/testsuite/gfortran.dg/pr88048.f90 (working copy)
@@ -0,0 +1,7 @@
+! { dg-do compile }
+! PR fortran/88048
+program p
+ integer, parameter :: a(2) = 1
+ data a(2) /a(1)/ ! { dg-error "definable entity" }
+ print *, a
+end
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-12-09 6:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-09 6:31 [Committed] PR fortran/88048 -- named constant can't be data object Steve Kargl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).