public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Mike Stump <mikestump@comcast.net>
Cc: Iain Sandoe <iain@sandoe.co.uk>,
	libstdc++ <libstdc++@gcc.gnu.org>,
	GCC-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, PPC/Darwin] Fix long double symbol exports.
Date: Mon, 10 Dec 2018 12:55:00 -0000	[thread overview]
Message-ID: <20181210125542.GO27131@redhat.com> (raw)
In-Reply-To: <18DD6609-83EF-46DA-A5D4-F25FB411B891@comcast.net>

On 06/12/18 14:36 -0800, Mike Stump wrote:
>On Dec 6, 2018, at 11:52 AM, Iain Sandoe <iain@sandoe.co.uk> wrote:
>>
>> During 8.x, the rs6000 target-specific mangling was reorganised which uncovered
>> a long-standing bug in Darwin’s mangling for ‘IBM’ long double.  Now the symbols
>> are correctly mangled, and we end up with a bunch of test link fails.
>>
>> This patch adds the necessary subset of the Linux long double exports to Darwin’s
>> export table.
>>
>> I have tested this on a few bootstrap/regtest cycles on powerpc-darwin9, and on the
>> power7 linux system.
>>
>> For the record, I’ve noted the library versions from the Linux side, although Darwin
>> does not version symbols in this way.
>>
>> OK for trunk and 8.x?
>
>Don't know if the libstdc++ want to review this or they want me to...  I'm fine with it.

Me too. OK for trunk and 8.x - thanks.

      reply	other threads:[~2018-12-10 12:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06 19:52 Iain Sandoe
2018-12-06 22:36 ` Mike Stump
2018-12-10 12:55   ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181210125542.GO27131@redhat.com \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iain@sandoe.co.uk \
    --cc=libstdc++@gcc.gnu.org \
    --cc=mikestump@comcast.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).