From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48383 invoked by alias); 10 Dec 2018 12:55:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 48329 invoked by uid 89); 10 Dec 2018 12:55:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=ibm, 8x, H*Ad:D*co.uk, H*Ad:U*libstdc X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Dec 2018 12:55:44 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 84D9F81DE3; Mon, 10 Dec 2018 12:55:43 +0000 (UTC) Received: from localhost (unknown [10.33.36.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id D6D3A600D6; Mon, 10 Dec 2018 12:55:42 +0000 (UTC) Date: Mon, 10 Dec 2018 12:55:00 -0000 From: Jonathan Wakely To: Mike Stump Cc: Iain Sandoe , libstdc++ , GCC-patches Subject: Re: [PATCH, PPC/Darwin] Fix long double symbol exports. Message-ID: <20181210125542.GO27131@redhat.com> References: <18DD6609-83EF-46DA-A5D4-F25FB411B891@comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <18DD6609-83EF-46DA-A5D4-F25FB411B891@comcast.net> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2018-12/txt/msg00570.txt.bz2 On 06/12/18 14:36 -0800, Mike Stump wrote: >On Dec 6, 2018, at 11:52 AM, Iain Sandoe wrote: >> >> During 8.x, the rs6000 target-specific mangling was reorganised which uncovered >> a long-standing bug in Darwin’s mangling for ‘IBM’ long double. Now the symbols >> are correctly mangled, and we end up with a bunch of test link fails. >> >> This patch adds the necessary subset of the Linux long double exports to Darwin’s >> export table. >> >> I have tested this on a few bootstrap/regtest cycles on powerpc-darwin9, and on the >> power7 linux system. >> >> For the record, I’ve noted the library versions from the Linux side, although Darwin >> does not version symbols in this way. >> >> OK for trunk and 8.x? > >Don't know if the libstdc++ want to review this or they want me to... I'm fine with it. Me too. OK for trunk and 8.x - thanks.