On Fri, 17 Aug 2018 18:39:00 +0200 Bernhard Reutner-Fischer wrote: > On 16 August 2018 17:46:43 CEST, Julian Brown > wrote: > >On Wed, 15 Aug 2018 21:56:54 +0200 > >Bernhard Reutner-Fischer wrote: > > > >> On 15 August 2018 18:46:37 CEST, Julian Brown > >> wrote: > >> >On Mon, 13 Aug 2018 12:06:21 -0700 > >> >Cesar Philippidis wrote: > >> > >> atttribute has more t than strictly necessary. > >> Don't like signed integer levels where they should be some > >> unsigned. Also don't like single switch cases instead of if. > >> And omitting function comments even if the hook way above is > >> documented may be ok ish but is a bit lazy ;) > > > >Here's a new version with those comments addressed. I also changed > >the logic around a little to avoid adding decls to the vec in > >omp_context which would never be given the gang-private attribute. > > > >Re-tested with offloading to NVPTX. > > > >OK? > > (TREE_CODE (var) == VAR_DECL > Is nowadays known as VAR_P (decl), FWIW. Fixed. (And also Tom's formatting nit mentioned in another email.) > ISTM that global variables are not JIT-friendly. > No further comments from me. Probably true, but AFAIK nobody's trying to use the (GCC) JIT with the PTX backend, and the backend already uses global variables for several other purposes. Of course PTX code is JIT'ted itself by the NVidia runtime, but I guess that's not what you were referring to! Is this version OK? Re-tested with offloading to NVPTX. Thanks, Julian