public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Alan Modra <amodra@gmail.com>
Cc: Andreas Tobler <andreast-list@fgznet.ch>,
	       GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] Fix bootstrap powerpc*-*-freebsd* targets
Date: Tue, 18 Dec 2018 09:20:00 -0000	[thread overview]
Message-ID: <20181218092002.GF3803@gate.crashing.org> (raw)
In-Reply-To: <20181218000927.GD30978@bubble.grove.modra.org>

Hi Alan,

On Tue, Dec 18, 2018 at 10:39:27AM +1030, Alan Modra wrote:
> On Mon, Dec 17, 2018 at 11:05:57AM -0600, Segher Boessenkool wrote:
> > On Mon, Dec 17, 2018 at 10:40:01AM +1030, Alan Modra wrote:
> > > Since I broke powerpc*-freebsd and the other non-linux powerpc
> > > targets, I guess I ought to fix them.  The following is a variation on
> > > your first patch, that results in -mcall-linux for powerpc-freebsd*
> > > providing the 32-bit powerpc-linux dynamic linker.
> > 
> > That, like the first patch, abuses that header file.  Please do it
> > somewhere sane instead, not in a random subtarget file?
> 
> Is there is a better place, currently?  sysv4.h contains a mess of OS
> related defines already, to support various -mcall options.  If those
> stay in sysv4.h I can't see a better place for the fall-back
> GNU_USER_DYNAMIC_LINKER define.

I was hoping you would untangle it a bit.  My dastardly plan failed,
apparently.  Drat.

Should anything use GNU_USER_DYNAMIC_LINKER if it isn't defined?  Maybe
it is better if the use in sysv4.h had an #ifdef around it?  For all the
other uses it should be always defined.

Or maybe we should have a linux32.h as well?


Segher

  reply	other threads:[~2018-12-18  9:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12 20:33 [patch] Fix bootstrap for non linux powerpc targets Andreas Tobler
2018-12-16 18:46 ` [patch] Fix bootstrap powerpc*-*-freebsd* targets Andreas Tobler
2018-12-17  0:10   ` Alan Modra
2018-12-17 17:06     ` Segher Boessenkool
2018-12-18  0:09       ` Alan Modra
2018-12-18  9:20         ` Segher Boessenkool [this message]
2018-12-18 12:49           ` Alan Modra
2018-12-18 16:14             ` Segher Boessenkool
2018-12-19  8:36         ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181218092002.GF3803@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=amodra@gmail.com \
    --cc=andreast-list@fgznet.ch \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).