From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108210 invoked by alias); 18 Dec 2018 09:20:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 108200 invoked by uid 89); 18 Dec 2018 09:20:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=somewhere X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Dec 2018 09:20:25 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id wBI9K9JR017735; Tue, 18 Dec 2018 03:20:10 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id wBI9K8HJ017649; Tue, 18 Dec 2018 03:20:08 -0600 Date: Tue, 18 Dec 2018 09:20:00 -0000 From: Segher Boessenkool To: Alan Modra Cc: Andreas Tobler , GCC Patches Subject: Re: [patch] Fix bootstrap powerpc*-*-freebsd* targets Message-ID: <20181218092002.GF3803@gate.crashing.org> References: <7d04429f-e633-0b5b-0d69-eae3c86634ca@fgznet.ch> <20181217001000.GA30978@bubble.grove.modra.org> <20181217170556.GY3803@gate.crashing.org> <20181218000927.GD30978@bubble.grove.modra.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181218000927.GD30978@bubble.grove.modra.org> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg01279.txt.bz2 Hi Alan, On Tue, Dec 18, 2018 at 10:39:27AM +1030, Alan Modra wrote: > On Mon, Dec 17, 2018 at 11:05:57AM -0600, Segher Boessenkool wrote: > > On Mon, Dec 17, 2018 at 10:40:01AM +1030, Alan Modra wrote: > > > Since I broke powerpc*-freebsd and the other non-linux powerpc > > > targets, I guess I ought to fix them. The following is a variation on > > > your first patch, that results in -mcall-linux for powerpc-freebsd* > > > providing the 32-bit powerpc-linux dynamic linker. > > > > That, like the first patch, abuses that header file. Please do it > > somewhere sane instead, not in a random subtarget file? > > Is there is a better place, currently? sysv4.h contains a mess of OS > related defines already, to support various -mcall options. If those > stay in sysv4.h I can't see a better place for the fall-back > GNU_USER_DYNAMIC_LINKER define. I was hoping you would untangle it a bit. My dastardly plan failed, apparently. Drat. Should anything use GNU_USER_DYNAMIC_LINKER if it isn't defined? Maybe it is better if the use in sysv4.h had an #ifdef around it? For all the other uses it should be always defined. Or maybe we should have a linux32.h as well? Segher