From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96550 invoked by alias); 18 Dec 2018 12:51:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 95482 invoked by uid 89); 18 Dec 2018 12:51:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=proceeds, 1336, spots, Hx-languages-length:1359 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Dec 2018 12:51:43 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E62C2C050DFB; Tue, 18 Dec 2018 12:51:41 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-117-214.ams2.redhat.com [10.36.117.214]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7A3251054FD9; Tue, 18 Dec 2018 12:51:41 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id wBICpc2p016056; Tue, 18 Dec 2018 13:51:39 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id wBICpcqp016055; Tue, 18 Dec 2018 13:51:38 +0100 Date: Tue, 18 Dec 2018 12:51:00 -0000 From: Jakub Jelinek To: cltang@codesourcery.com Cc: gcc-patches@gcc.gnu.org, Thomas Schwinge Subject: Re: [PATCH, OpenACC, 4/8] Multi-dimensional dynamic array support for OpenACC data clauses, omp-low: dynamic array descriptor creation Message-ID: <20181218125137.GL23305@tucnak> Reply-To: Jakub Jelinek References: <4c8edea9-4685-2c19-d742-9f1a63e89f91@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg01297.txt.bz2 On Thu, Dec 13, 2018 at 10:52:32PM +0800, Chung-Lin Tang wrote: > --- gcc/omp-low.c (revision 267050) > +++ gcc/omp-low.c (working copy) > @@ -60,6 +60,7 @@ along with GCC; see the file COPYING3. If not see > #include "hsa-common.h" > #include "stringpool.h" > #include "attribs.h" > +#include "tree-hash-traits.h" > > /* Lowering of OMP parallel and workshare constructs proceeds in two > phases. The first phase scans the function looking for OMP statements > @@ -133,6 +134,9 @@ struct omp_context > > /* True if this construct can be cancelled. */ > bool cancellable; > + > + /* Hash map of dynamic arrays in this context. */ > + hash_map *dynamic_arrays; You still call it dynamic arrays. Call it array descriptors or something similar. In the comment too. > > +/* Helper function for create_dynamic_array_descr_type(), to append a new field Here too and many other spots. > + tree da_descr_type, name, x; Even here. > + append_field_to_record_type (da_descr_type, get_identifier ("$dim_num"), > + sizetype); Why the $s in the identifiers? Use . or __ if it shouldn't be user accessible. Think whether you want it to be in debuginfo or not, if not, it should be DECL_IGNORED_P. Jakub