From: Segher Boessenkool <segher@kernel.crashing.org>
To: Alan Modra <amodra@gmail.com>
Cc: Andreas Tobler <andreast-list@fgznet.ch>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] Fix bootstrap powerpc*-*-freebsd* targets
Date: Wed, 19 Dec 2018 08:36:00 -0000 [thread overview]
Message-ID: <20181219083536.GM3803@gate.crashing.org> (raw)
In-Reply-To: <20181218000927.GD30978@bubble.grove.modra.org>
On Tue, Dec 18, 2018 at 10:39:27AM +1030, Alan Modra wrote:
> On Mon, Dec 17, 2018 at 11:05:57AM -0600, Segher Boessenkool wrote:
> > Hi!
> >
> > On Mon, Dec 17, 2018 at 10:40:01AM +1030, Alan Modra wrote:
> > > Since I broke powerpc*-freebsd and the other non-linux powerpc
> > > targets, I guess I ought to fix them. The following is a variation on
> > > your first patch, that results in -mcall-linux for powerpc-freebsd*
> > > providing the 32-bit powerpc-linux dynamic linker.
> >
> > That, like the first patch, abuses that header file. Please do it
> > somewhere sane instead, not in a random subtarget file?
>
> Is there is a better place, currently? sysv4.h contains a mess of OS
> related defines already, to support various -mcall options. If those
> stay in sysv4.h I can't see a better place for the fall-back
> GNU_USER_DYNAMIC_LINKER define.
>
> Here's the problem:
> powerpc*-*-linux* uses tm_file="rs6000/rs6000.h dbxelf.h elfos.h
> gnu-user.h linux.h freebsd-spec.h rs6000/sysv4.h" plus a few more.
> linux.h contains the proper GNU_USER_DYNAMIC_LINKER define for linux.
> Fairly obviously we can't put a fallback define in rs6000/rs6000.h
> for those targets that don't include linux.h (and including linux.h
> for non-linux targets is probably not a good idea).
>
> Besides rs6000/sysv4.h, you could put the fallback in rs6000/freebsd.h
> to fix powerpc*-freebsd*, but then you'd need to put it in
> rs6000/netbsd.h, rs6000/eabi.h, rs6000/rtems.h, rs6000/vxworks.h,
> rs6000/lynx.h to fix those targets. That would be horrible. And it
> would leave powerpc-elf broken.
>
> >
> > > * config/rs6000/sysv4.h (GNU_USER_DYNAMIC_LINKER): Define.
The patch is okay for now, btw. Thanks!
Segher
prev parent reply other threads:[~2018-12-19 8:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 20:33 [patch] Fix bootstrap for non linux powerpc targets Andreas Tobler
2018-12-16 18:46 ` [patch] Fix bootstrap powerpc*-*-freebsd* targets Andreas Tobler
2018-12-17 0:10 ` Alan Modra
2018-12-17 17:06 ` Segher Boessenkool
2018-12-18 0:09 ` Alan Modra
2018-12-18 9:20 ` Segher Boessenkool
2018-12-18 12:49 ` Alan Modra
2018-12-18 16:14 ` Segher Boessenkool
2018-12-19 8:36 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181219083536.GM3803@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=amodra@gmail.com \
--cc=andreast-list@fgznet.ch \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).