From: Jakub Jelinek <jakub@redhat.com>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Patch ping (Re: [C++ PATCH] Fix __builtin_{is_constant_evaluated,constant_p} handling in static_assert (PR c++/86524, PR c++/88446))
Date: Wed, 19 Dec 2018 10:19:00 -0000 [thread overview]
Message-ID: <20181219101935.GX23305@tucnak> (raw)
In-Reply-To: <20181212223037.GL12380@tucnak>
Hi!
On Wed, Dec 12, 2018 at 11:30:37PM +0100, Jakub Jelinek wrote:
> 2018-12-12 Jakub Jelinek <jakub@redhat.com>
>
> PR c++/86524
> PR c++/88446
> * cp-tree.h (fold_non_dependent_expr): Add manifestly_const_eval
> argument.
> * constexpr.c (cxx_eval_builtin_function_call): Evaluate
> __builtin_constant_p if ctx->manifestly_const_eval even in constexpr
> functions. For arguments to builtins, if ctx->manifestly_const_eval
> try to first evaluate arguments with it, but if that doesn't result
> in a constant expression, retry without it. Fix comment typo.
> (fold_non_dependent_expr): Add manifestly_const_eval argument, pass
> it through to cxx_eval_outermost_constant_expr and
> maybe_constant_value.
> * semantics.c (finish_static_assert): Call fold_non_dependent_expr
> with true as manifestly_const_eval.
>
> * g++.dg/cpp1y/constexpr-86524.C: New test.
> * g++.dg/cpp2a/is-constant-evaluated4.C: New test.
> * g++.dg/cpp2a/is-constant-evaluated5.C: New test.
> * g++.dg/cpp2a/is-constant-evaluated6.C: New test.
I'd like to ping this patch.
Thanks.
Jakub
next prev parent reply other threads:[~2018-12-19 10:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 22:30 [C++ PATCH] Fix __builtin_{is_constant_evaluated,constant_p} handling in static_assert (PR c++/86524, PR c++/88446) Jakub Jelinek
2018-12-19 10:19 ` Jakub Jelinek [this message]
2018-12-20 19:49 ` Jason Merrill
2018-12-20 21:26 ` Jakub Jelinek
2018-12-20 21:28 ` Jason Merrill
2018-12-20 21:43 ` Jakub Jelinek
2018-12-20 21:47 ` Jason Merrill
2018-12-20 22:41 ` Jakub Jelinek
2018-12-21 2:51 ` Jason Merrill
2018-12-21 9:05 ` [C++ PATCH] Fix __builtin_{is_constant_evaluated,constant_p} handling in static_assert (PR c++/86524, PR c++/88446, take 2) Jakub Jelinek
2018-12-21 19:31 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181219101935.GX23305@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).