From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] PR fortran/87992 -- trivially stupid patch, but ...
Date: Wed, 19 Dec 2018 22:34:00 -0000 [thread overview]
Message-ID: <20181219223452.GA12545@troutmask.apl.washington.edu> (raw)
In-Reply-To: <20181216174225.GA58470@troutmask.apl.washington.edu>
On Sun, Dec 16, 2018 at 09:42:25AM -0800, Steve Kargl wrote:
> The following patch removes the ICE reported in PR fortran/87992,
> and restores the behavior observed with gfortran 7 and 8 (ie,
> code compiles).
>
> The PR marks the code with ice-on-invalid-code. I don't use
> CLASS in any of code and have never read the standard nor a
> Fortran book about CLASS. If the code is invalid, is gfortran
> required by a constraint to reject the code. If yes, someone
> with CLASS will need to address this PR; otherwise, I will
> commit the patch and close it as FIXED.
>
> PS: the patch simply checks for a non-NULL pointer.
>
> Index: gcc/fortran/resolve.c
> ===================================================================
> --- gcc/fortran/resolve.c (revision 267190)
> +++ gcc/fortran/resolve.c (working copy)
> @@ -12313,7 +12313,11 @@ resolve_fl_variable (gfc_symbol *sym, int mp_flag)
> {
> /* Make sure that character string variables with assumed length are
> dummy arguments. */
> - e = sym->ts.u.cl->length;
> + if (sym->ts.u.cl)
> + e = sym->ts.u.cl->length;
> + else
> + return false;
> +
> if (e == NULL && !sym->attr.dummy && !sym->attr.result
> && !sym->ts.deferred && !sym->attr.select_type_temporary
> && !sym->attr.omp_udr_artificial_var)
> Index: gcc/testsuite/gfortran.dg/pr87992.f90
> ===================================================================
> --- gcc/testsuite/gfortran.dg/pr87992.f90 (nonexistent)
> +++ gcc/testsuite/gfortran.dg/pr87992.f90 (working copy)
> @@ -0,0 +1,5 @@
> +! { dg-do compile }
> +subroutine s(x)
> + class(*), allocatable :: x
> + x = ''
> +end
>
Patched committed on trunk after verification from
Gerhard that the code is valid Fortran.
--
Steve
prev parent reply other threads:[~2018-12-19 22:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 17:42 Steve Kargl
2018-12-19 22:34 ` Steve Kargl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181219223452.GA12545@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).