From: Julian Brown <julian@codesourcery.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Martin Jambor <mjambor@suse.cz>,
Cesar Philippidis <cesar@codesourcery.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Thomas Schwinge <thomas@codesourcery.com>
Subject: Re: [patch,openacc] Fix PR71959: lto dump of callee counts
Date: Fri, 21 Dec 2018 17:09:00 -0000 [thread overview]
Message-ID: <20181221164732.53df29f8@squid.athome> (raw)
In-Reply-To: <20181221133119.GF23305@tucnak>
Hi Jakub,
Thanks for review!
On Fri, 21 Dec 2018 14:31:19 +0100
Jakub Jelinek <jakub@redhat.com> wrote:
> On Fri, Dec 21, 2018 at 01:23:03PM +0000, Julian Brown wrote:
> > 2018-xx-yy Nathan Sidwell <nathan@acm.org>
> >
> > PR lto/71959
> > libgomp/
> > * testsuite/libgomp.oacc-c++/pr71959-a.C: New.
> > * testsuite/libgomp.oacc-c++/pr71959.C: New.
>
> Just nits, better use pr71959-aux.cc (*.cc files aren't considered as
> testcases by *.exp:
> set tests [lsort [concat \
> [find $srcdir/$subdir *.C] \
> [find
> $srcdir/$subdir/../libgomp.oacc-c-c++-common *.c]]] ) and just a is
> weird.
Fixed.
> > commit c69dce8ba0ecd7ff620f4f1b8dacc94c61984107
> > Author: Julian Brown <julian@codesourcery.com>
> > Date: Wed Dec 19 05:01:58 2018 -0800
> >
> > Add testcase from PR71959
> >
> > libgomp/
>
> Please mention
> PR lto/71959
> here in the ChangeLog.
Fixed.
> > * testsuite/libgomp.oacc-c++/pr71959-a.C: New.
> > * testsuite/libgomp.oacc-c++/pr71959.C: New.
>
> > +void apply (int (*fn)(), Iter out) asm
> > ("_ZN5Apply5applyEPFivE4Iter");
>
> Will this work even on targets that use _ or other symbol prefixes?
I'd guess so, else there would be no portable way of using "asm" to
write pre-mangled C++ names. The only existing similar uses I could find
in the testsuite are for the ifunc attribute, not asm, though (e.g.
g++.dg/ext/attr-ifunc-*.C).
Anyway, OpenACC is only useful for a handful of targets at present,
neither of which use special symbol prefixes AFAIK.
> > --- /dev/null
> > +++ b/libgomp/testsuite/libgomp.oacc-c++/pr71959.C
> > @@ -0,0 +1,31 @@
> > +// { dg-additional-sources "pr71959-a.C" }
> > +
> > +// pr lto/71959 ICEd LTO due to mismatch between writing & reading
> > behaviour
>
> Capital PR instead of pr .
Fixed. OK now?
Thanks,
Julian
next prev parent reply other threads:[~2018-12-21 16:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 18:06 Cesar Philippidis
2018-09-25 13:01 ` Martin Jambor
2018-12-21 3:45 ` Julian Brown
2018-12-21 13:29 ` Julian Brown
2018-12-21 13:32 ` Jakub Jelinek
2018-12-21 17:09 ` Julian Brown [this message]
2018-12-22 18:53 ` Iain Sandoe
2019-01-08 13:31 ` Julian Brown
2019-01-08 13:36 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221164732.53df29f8@squid.athome \
--to=julian@codesourcery.com \
--cc=cesar@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mjambor@suse.cz \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).