From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60426 invoked by alias); 21 Dec 2018 16:47:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60416 invoked by uid 89); 21 Dec 2018 16:47:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Capital X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Dec 2018 16:47:39 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-04.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1gaNxZ-0001xD-6z from Julian_Brown@mentor.com ; Fri, 21 Dec 2018 08:47:37 -0800 Received: from squid.athome (137.202.0.90) by SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Fri, 21 Dec 2018 16:47:33 +0000 Date: Fri, 21 Dec 2018 17:09:00 -0000 From: Julian Brown To: Jakub Jelinek CC: Martin Jambor , Cesar Philippidis , "gcc-patches@gcc.gnu.org" , Thomas Schwinge Subject: Re: [patch,openacc] Fix PR71959: lto dump of callee counts Message-ID: <20181221164732.53df29f8@squid.athome> In-Reply-To: <20181221133119.GF23305@tucnak> References: <319b3ebd-c601-449b-718c-963b68414224@codesourcery.com> <20181221025636.3f9b377c@squid.athome> <20181221132303.1ab86f96@squid.athome> <20181221133119.GF23305@tucnak> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg01582.txt.bz2 Hi Jakub, Thanks for review! On Fri, 21 Dec 2018 14:31:19 +0100 Jakub Jelinek wrote: > On Fri, Dec 21, 2018 at 01:23:03PM +0000, Julian Brown wrote: > > 2018-xx-yy Nathan Sidwell > > > > PR lto/71959 > > libgomp/ > > * testsuite/libgomp.oacc-c++/pr71959-a.C: New. > > * testsuite/libgomp.oacc-c++/pr71959.C: New. > > Just nits, better use pr71959-aux.cc (*.cc files aren't considered as > testcases by *.exp: > set tests [lsort [concat \ > [find $srcdir/$subdir *.C] \ > [find > $srcdir/$subdir/../libgomp.oacc-c-c++-common *.c]]] ) and just a is > weird. Fixed. > > commit c69dce8ba0ecd7ff620f4f1b8dacc94c61984107 > > Author: Julian Brown > > Date: Wed Dec 19 05:01:58 2018 -0800 > > > > Add testcase from PR71959 > > > > libgomp/ > > Please mention > PR lto/71959 > here in the ChangeLog. Fixed. > > * testsuite/libgomp.oacc-c++/pr71959-a.C: New. > > * testsuite/libgomp.oacc-c++/pr71959.C: New. > > > +void apply (int (*fn)(), Iter out) asm > > ("_ZN5Apply5applyEPFivE4Iter"); > > Will this work even on targets that use _ or other symbol prefixes? I'd guess so, else there would be no portable way of using "asm" to write pre-mangled C++ names. The only existing similar uses I could find in the testsuite are for the ifunc attribute, not asm, though (e.g. g++.dg/ext/attr-ifunc-*.C). Anyway, OpenACC is only useful for a handful of targets at present, neither of which use special symbol prefixes AFAIK. > > --- /dev/null > > +++ b/libgomp/testsuite/libgomp.oacc-c++/pr71959.C > > @@ -0,0 +1,31 @@ > > +// { dg-additional-sources "pr71959-a.C" } > > + > > +// pr lto/71959 ICEd LTO due to mismatch between writing & reading > > behaviour > > Capital PR instead of pr . Fixed. OK now? Thanks, Julian