From: Jakub Jelinek <jakub@redhat.com>
To: Martin Sebor <msebor@gmail.com>
Cc: gcc-patches@gcc.gnu.org,
"Joseph S. Myers" <joseph@codesourcery.com>,
Marek Polacek <polacek@redhat.com>,
Jason Merrill <jason@redhat.com>,
Richard Biener <rguenther@suse.de>
Subject: Re: [PATCH] attribute copy, leaf, weakref and -Wmisisng-attributes (PR 88546)
Date: Sat, 22 Dec 2018 00:33:00 -0000 [thread overview]
Message-ID: <20181222001642.GL23305@tucnak> (raw)
In-Reply-To: <2f0b2202-ba56-0554-1cc9-f290cda2a740@gmail.com>
On Fri, Dec 21, 2018 at 04:50:47PM -0700, Martin Sebor wrote:
> The first revision of the patch was missing a test and didn't
> completely or completely correctly handle attribute noreturn.
> Attached is an update with the test included and the omission
> and bug fixed.
>
> I think it makes sense to consider the patch independently of
> the question whether weakrefs should be extern. That change can
Weakrefs shouldn't be extern, that is what we were using initially and
changed to static. At this point we can't change that again IMNSHO.
Jakub
next prev parent reply other threads:[~2018-12-22 0:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 6:01 Martin Sebor
2018-12-21 10:28 ` Jakub Jelinek
2018-12-21 16:05 ` Martin Sebor
2018-12-21 19:14 ` Joseph Myers
2018-12-22 0:16 ` Martin Sebor
2018-12-22 0:33 ` Jakub Jelinek [this message]
2018-12-22 2:13 ` Martin Sebor
2019-01-03 22:10 ` Martin Sebor
2019-01-03 22:10 ` Martin Sebor
2019-01-04 18:10 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181222001642.GL23305@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=msebor@gmail.com \
--cc=polacek@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).