From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45768 invoked by alias); 22 Dec 2018 00:16:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 45759 invoked by uid 89); 22 Dec 2018 00:16:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 22 Dec 2018 00:16:53 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DCA3F8762E; Sat, 22 Dec 2018 00:16:51 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-117-214.ams2.redhat.com [10.36.117.214]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B31045C1A1; Sat, 22 Dec 2018 00:16:47 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id wBM0GjN9004102; Sat, 22 Dec 2018 01:16:45 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id wBM0GggO004101; Sat, 22 Dec 2018 01:16:42 +0100 Date: Sat, 22 Dec 2018 00:33:00 -0000 From: Jakub Jelinek To: Martin Sebor Cc: gcc-patches@gcc.gnu.org, "Joseph S. Myers" , Marek Polacek , Jason Merrill , Richard Biener Subject: Re: [PATCH] attribute copy, leaf, weakref and -Wmisisng-attributes (PR 88546) Message-ID: <20181222001642.GL23305@tucnak> Reply-To: Jakub Jelinek References: <6ff6565b-51d8-8620-f345-a0082747297b@gmail.com> <2f0b2202-ba56-0554-1cc9-f290cda2a740@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f0b2202-ba56-0554-1cc9-f290cda2a740@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg01618.txt.bz2 On Fri, Dec 21, 2018 at 04:50:47PM -0700, Martin Sebor wrote: > The first revision of the patch was missing a test and didn't > completely or completely correctly handle attribute noreturn. > Attached is an update with the test included and the omission > and bug fixed. > > I think it makes sense to consider the patch independently of > the question whether weakrefs should be extern. That change can Weakrefs shouldn't be extern, that is what we were using initially and changed to static. At this point we can't change that again IMNSHO. Jakub