From: Jonathan Wakely <jwakely@redhat.com>
To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] PR libstdc++/88607 replace or remove unnecessary UTF-8 characters
Date: Sun, 06 Jan 2019 00:49:00 -0000 [thread overview]
Message-ID: <20190106004941.GI15627@redhat.com> (raw)
In-Reply-To: <20190103224415.GD15627@redhat.com>
On 03/01/19 22:44 +0000, Jonathan Wakely wrote:
>On 03/01/19 22:07 +0000, Jonathan Wakely wrote:
>>On 03/01/19 20:38 +0000, Jonathan Wakely wrote:
>>>There are a number of UTF-8 characters in comments which add no value
>>>and can be replaced with ASCII equivalents, or removed entirely for the
>>>section sign (U+00A7).
>>>
>>> PR libstdc++/88607
>>> * include/bits/forward_list.h: Replace UTF-8 "ligature fi" character.
>>> * include/debug/forward_list: Likewise.
>>> * include/experimental/bits/shared_ptr.h: Remove UTF-8 "section sign"
>>> character.
>>> * include/experimental/chrono: Likewise.
>>> * include/experimental/functional: Likewise.
>>> * include/experimental/ratio: Likewise.
>>> * include/experimental/system_error: Likewise.
>>> * include/experimental/tuple: Likewise.
>>> * include/experimental/type_traits: Likewise.
>>> * include/parallel/workstealing.h: Replace UTF-8 "en dash" character.
>>> * include/parallel/multiseq_selection.h: Likewise.
>>
>>This replaces some more non-ASCII characters.
>>
>>Tested powerpc64-linux, committed to trunk.
>
>The tests added by this patch would probably be a good idea, but I'm
>not sure if -finput-charset=ascii works for all targets.
This is committed to trunk now. If some targets fail the test we can
deal with them as needed.
>commit 53a31b41d06059fdaf1f09fd66f5d9e219246759
>Author: Jonathan Wakely <jwakely@redhat.com>
>Date: Thu Jan 3 22:18:14 2019 +0000
>
> PR libstdc++/88607 add tests using -finput-charset=ascii
>
> This verifies that the <bits/extc++.h> header can be compiled with ASCII
> as the input character set.
>
> PR libstdc++/88607
> * testsuite/17_intro/headers/c++1998/charset.cc: New test.
> * testsuite/17_intro/headers/c++2011/charset.cc: New test.
> * testsuite/17_intro/headers/c++2014/charset.cc: New test.
> * testsuite/17_intro/headers/c++2017/charset.cc: New test.
> * testsuite/17_intro/headers/c++2020/charset.cc: New test.
>
>diff --git a/libstdc++-v3/testsuite/17_intro/headers/c++1998/charset.cc b/libstdc++-v3/testsuite/17_intro/headers/c++1998/charset.cc
>new file mode 100644
>index 00000000000..864c64ef831
>--- /dev/null
>+++ b/libstdc++-v3/testsuite/17_intro/headers/c++1998/charset.cc
>@@ -0,0 +1,4 @@
>+// { dg-options "-finput-charset=ascii" }
>+// { dg-do compile }
>+
>+#include <bits/extc++.h>
>diff --git a/libstdc++-v3/testsuite/17_intro/headers/c++2011/charset.cc b/libstdc++-v3/testsuite/17_intro/headers/c++2011/charset.cc
>new file mode 100644
>index 00000000000..864c64ef831
>--- /dev/null
>+++ b/libstdc++-v3/testsuite/17_intro/headers/c++2011/charset.cc
>@@ -0,0 +1,4 @@
>+// { dg-options "-finput-charset=ascii" }
>+// { dg-do compile }
>+
>+#include <bits/extc++.h>
>diff --git a/libstdc++-v3/testsuite/17_intro/headers/c++2014/charset.cc b/libstdc++-v3/testsuite/17_intro/headers/c++2014/charset.cc
>new file mode 100644
>index 00000000000..864c64ef831
>--- /dev/null
>+++ b/libstdc++-v3/testsuite/17_intro/headers/c++2014/charset.cc
>@@ -0,0 +1,4 @@
>+// { dg-options "-finput-charset=ascii" }
>+// { dg-do compile }
>+
>+#include <bits/extc++.h>
>diff --git a/libstdc++-v3/testsuite/17_intro/headers/c++2017/charset.cc b/libstdc++-v3/testsuite/17_intro/headers/c++2017/charset.cc
>new file mode 100644
>index 00000000000..864c64ef831
>--- /dev/null
>+++ b/libstdc++-v3/testsuite/17_intro/headers/c++2017/charset.cc
>@@ -0,0 +1,4 @@
>+// { dg-options "-finput-charset=ascii" }
>+// { dg-do compile }
>+
>+#include <bits/extc++.h>
>diff --git a/libstdc++-v3/testsuite/17_intro/headers/c++2020/charset.cc b/libstdc++-v3/testsuite/17_intro/headers/c++2020/charset.cc
>new file mode 100644
>index 00000000000..864c64ef831
>--- /dev/null
>+++ b/libstdc++-v3/testsuite/17_intro/headers/c++2020/charset.cc
>@@ -0,0 +1,4 @@
>+// { dg-options "-finput-charset=ascii" }
>+// { dg-do compile }
>+
>+#include <bits/extc++.h>
prev parent reply other threads:[~2019-01-06 0:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 20:38 Jonathan Wakely
2019-01-03 22:07 ` Jonathan Wakely
2019-01-03 22:44 ` Jonathan Wakely
2019-01-06 0:49 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190106004941.GI15627@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).